Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 657863002: Improve String.repeat. (Closed)

Created:
6 years, 2 months ago by Yang
Modified:
6 years, 2 months ago
Reviewers:
aandrey, Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Improve String.repeat. Adapted from patch contributed by Isiah Meadows <impinball@gmail.com>;. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24687

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M src/harmony-string.js View 1 1 chunk +9 lines, -6 lines 0 comments Download
M test/mjsunit/harmony/string-repeat.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Yang
6 years, 2 months ago (2014-10-15 13:49:26 UTC) #1
Jakob Kummerow
lgtm
6 years, 2 months ago (2014-10-15 14:01:51 UTC) #2
aandrey
https://codereview.chromium.org/657863002/diff/1/src/harmony-string.js File src/harmony-string.js (right): https://codereview.chromium.org/657863002/diff/1/src/harmony-string.js#newcode30 src/harmony-string.js:30: s += s; There will be extra unnecessary concatenation ...
6 years, 2 months ago (2014-10-15 17:54:43 UTC) #4
Yang
6 years, 2 months ago (2014-10-17 10:01:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24687 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698