content/browser/renderer_host/input/input_router_impl_unittest.cc - Issue 657803002: Update touch selection to only modify one selection point at a time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/input_router_impl_unittest.cc

Issue 657803002: Update touch selection to only modify one selection point at a time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More updates Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/input/input_router_impl.cc ('K') | « content/browser/renderer_host/input/input_router_impl.cc ('k') | content/browser/renderer_host/input/touch_selection_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/input_router_impl_unittest.cc

diff --git a/content/browser/renderer_host/input/input_router_impl_unittest.cc b/content/browser/renderer_host/input/input_router_impl_unittest.cc

index 732682113476fc295c7f38d96442e80d7ef96e80..f65b1e244e52a4105ac7a1643c51831a046f8482 100644

--- a/content/browser/renderer_host/input/input_router_impl_unittest.cc

+++ b/content/browser/renderer_host/input/input_router_impl_unittest.cc

@@ -354,7 +354,7 @@ TEST_F(InputRouterImplTest, CoalescesRangeSelection) {

// Now ack the first message.

{

- scoped_ptr<IPC::Message> response(new ViewHostMsg_SelectRange_ACK(0));

+ scoped_ptr<IPC::Message> response(new InputHostMsg_SelectRange_ACK(0));

jdduke (slow) 2014/10/27 15:22:13 Maybe a short test that interleaves RangeSelection

input_router_->OnMessageReceived(*response);

}

@@ -367,7 +367,7 @@ TEST_F(InputRouterImplTest, CoalescesRangeSelection) {

// Acking the coalesced msg should not send any more msg.

{

- scoped_ptr<IPC::Message> response(new ViewHostMsg_SelectRange_ACK(0));

+ scoped_ptr<IPC::Message> response(new InputHostMsg_SelectRange_ACK(0));

input_router_->OnMessageReceived(*response);

}

EXPECT_EQ(0u, GetSentMessageCountAndResetSink());

@@ -391,7 +391,7 @@ TEST_F(InputRouterImplTest, CoalescesCaretMove) {

// Now ack the first message.

{

- scoped_ptr<IPC::Message> response(new ViewHostMsg_MoveCaret_ACK(0));

+ scoped_ptr<IPC::Message> response(new InputHostMsg_MoveCaret_ACK(0));

input_router_->OnMessageReceived(*response);

}

@@ -402,7 +402,7 @@ TEST_F(InputRouterImplTest, CoalescesCaretMove) {

// Acking the coalesced msg should not send any more msg.

{

- scoped_ptr<IPC::Message> response(new ViewHostMsg_MoveCaret_ACK(0));

+ scoped_ptr<IPC::Message> response(new InputHostMsg_MoveCaret_ACK(0));

input_router_->OnMessageReceived(*response);

}

EXPECT_EQ(0u, GetSentMessageCountAndResetSink());