Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: content/browser/renderer_host/input/input_router_impl.h

Issue 657803002: Update touch selection to only modify one selection point at a time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More updates Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/input_router_impl.h
diff --git a/content/browser/renderer_host/input/input_router_impl.h b/content/browser/renderer_host/input/input_router_impl.h
index 0f7b023bfd6fe3e7233a5bd23e43d3d33acf0cee..ad95d189316a0be51eb5ad5a0c5c229ceffd714a 100644
--- a/content/browser/renderer_host/input/input_router_impl.h
+++ b/content/browser/renderer_host/input/input_router_impl.h
@@ -98,7 +98,7 @@ private:
InputEventAckState ack_result) override;
bool SendMoveCaret(scoped_ptr<IPC::Message> message);
- bool SendSelectRange(scoped_ptr<IPC::Message> message);
+ bool SendSelectMessage(scoped_ptr<IPC::Message> message);
bool Send(IPC::Message* message);
// Filters and forwards |input_event| to the appropriate handler.
@@ -151,7 +151,7 @@ private:
void OnInputEventAck(const InputHostMsg_HandleInputEvent_ACK_Params& ack);
void OnDidOverscroll(const DidOverscrollParams& params);
void OnMsgMoveCaretAck();
- void OnSelectRangeAck();
+ void OnSelectMessageAck();
void OnHasTouchEventHandlers(bool has_handlers);
void OnSetTouchAction(TouchAction touch_action);
@@ -215,11 +215,13 @@ private:
InputAckHandler* ack_handler_;
int routing_id_;
- // (Similar to |mouse_move_pending_|.) True while waiting for SelectRange_ACK.
- bool select_range_pending_;
+ // (Similar to |mouse_move_pending_|.) True while waiting for SelectRange_ACK
+ // or MoveRangeSelectionExtent_ACK.
+ bool select_message_pending_;
- // (Similar to |next_mouse_move_|.) The next SelectRange to send, if any.
- scoped_ptr<IPC::Message> next_selection_range_;
+ // Queue of pending select messages to send after receving the next select
+ // message ack.
+ std::deque<IPC::Message*> pending_select_messages_;
// (Similar to |mouse_move_pending_|.) True while waiting for MoveCaret_ACK.
bool move_caret_pending_;

Powered by Google App Engine
This is Rietveld 408576698