Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: content/common/input_messages.h

Issue 657803002: Update touch selection to only modify one selection point at a time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix DCHECK Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/input_messages.h
diff --git a/content/common/input_messages.h b/content/common/input_messages.h
index 1827212699c9acb9e3283ddd7f975834ee66f34f..3fc24878407c06dc628c470fce44c5f1e663b0c6 100644
--- a/content/common/input_messages.h
+++ b/content/common/input_messages.h
@@ -199,8 +199,13 @@ IPC_MESSAGE_ROUTED0(InputMsg_Unselect)
// Requests the renderer to select the region between two points.
// Expects a SelectRange_ACK message when finished.
IPC_MESSAGE_ROUTED2(InputMsg_SelectRange,
- gfx::Point /* start */,
- gfx::Point /* end */)
+ gfx::Point /* base */,
+ gfx::Point /* extent */)
+
+// Requests the renderer to move the selection extent point to a new position.
+// Expects a MoveRangeSelectionExtent_ACK message when finished.
+IPC_MESSAGE_ROUTED1(InputMsg_MoveRangeSelectionExtent,
+ gfx::Point /* point */)
jdduke (slow) 2014/10/21 16:57:36 Nit: Let's call this extent for consistency.
// Requests the renderer to move the caret selection toward the point.
// Expects a MoveCaret_ACK message when finished.
@@ -237,6 +242,15 @@ IPC_MESSAGE_ROUTED1(InputHostMsg_SetTouchAction,
IPC_MESSAGE_ROUTED1(InputHostMsg_DidOverscroll,
content::DidOverscrollParams /* params */)
+// Acknowledges receipt of a InputMsg_MoveCaret message.
+IPC_MESSAGE_ROUTED0(InputHostMsg_MoveCaret_ACK)
+
+// Acknowledges receipt of a InputMsg_MoveRangeSelectionExtent message.
+IPC_MESSAGE_ROUTED0(InputHostMsg_MoveRangeSelectionExtent_ACK)
+
+// Acknowledges receipt of a InputMsg_SelectRange message.
+IPC_MESSAGE_ROUTED0(InputHostMsg_SelectRange_ACK)
+
// Required for cancelling an ongoing input method composition.
IPC_MESSAGE_ROUTED0(InputHostMsg_ImeCancelComposition)

Powered by Google App Engine
This is Rietveld 408576698