content/browser/renderer_host/input/touch_selection_controller.h - Issue 657803002: Update touch selection to only modify one selection point at a time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/touch_selection_controller.h

Issue 657803002: Update touch selection to only modify one selection point at a time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/input_router_impl_unittest.cc ('k') | content/browser/renderer_host/input/touch_selection_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/touch_selection_controller.h

diff --git a/content/browser/renderer_host/input/touch_selection_controller.h b/content/browser/renderer_host/input/touch_selection_controller.h

index 1ded1a97a1c7e607200cf918782cd968b9cbf3f7..abe4ed46facc761a046c708cf0adaf51825a39f9 100644

--- a/content/browser/renderer_host/input/touch_selection_controller.h

+++ b/content/browser/renderer_host/input/touch_selection_controller.h

@@ -31,8 +31,9 @@ class CONTENT_EXPORT TouchSelectionControllerClient {

virtual bool SupportsAnimation() const = 0;

virtual void SetNeedsAnimate() = 0;

virtual void MoveCaret(const gfx::PointF& position) = 0;

- virtual void SelectBetweenCoordinates(const gfx::PointF& start,

- const gfx::PointF& end) = 0;

+ virtual void MoveRangeSelectionExtent(const gfx::PointF& extent) = 0;

+ virtual void SelectBetweenCoordinates(const gfx::PointF& base,

+ const gfx::PointF& extent) = 0;

virtual void OnSelectionEvent(SelectionEventType event,

const gfx::PointF& position) = 0;

virtual scoped_ptr<TouchHandleDrawable> CreateDrawable() = 0;

@@ -133,7 +134,6 @@ class CONTENT_EXPORT TouchSelectionController : public TouchHandleClient {

scoped_ptr<TouchHandle> start_selection_handle_;

scoped_ptr<TouchHandle> end_selection_handle_;

- gfx::PointF fixed_handle_position_;

bool is_selection_active_;

bool activate_selection_automatically_;