Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 657803002: Update touch selection to only modify one selection point at a time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address issues and add tests Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index e7336e28507d7b642b2e5d92abf23f454822a89b..330335c9104fe72150d9710610eb4a93263986de 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -1140,11 +1140,17 @@ void RenderWidgetHostViewAndroid::MoveCaret(const gfx::PointF& position) {
MoveCaret(gfx::Point(position.x(), position.y()));
}
+void RenderWidgetHostViewAndroid::MoveRangeSelectionExtent(
+ const gfx::PointF& extent) {
+ DCHECK(content_view_core_);
+ content_view_core_->MoveRangeSelectionExtent(extent);
no sievers 2014/11/04 22:12:10 It seems a bit odd that we are going back from RWH
+}
+
void RenderWidgetHostViewAndroid::SelectBetweenCoordinates(
- const gfx::PointF& start,
- const gfx::PointF& end) {
+ const gfx::PointF& base,
+ const gfx::PointF& extent) {
DCHECK(content_view_core_);
- content_view_core_->SelectBetweenCoordinates(start, end);
+ content_view_core_->SelectBetweenCoordinates(base, extent);
}
void RenderWidgetHostViewAndroid::OnSelectionEvent(

Powered by Google App Engine
This is Rietveld 408576698