Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1941)

Unified Diff: content/browser/renderer_host/input/touch_selection_controller.h

Issue 657803002: Update touch selection to only modify one selection point at a time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/touch_selection_controller.h
diff --git a/content/browser/renderer_host/input/touch_selection_controller.h b/content/browser/renderer_host/input/touch_selection_controller.h
index 4e33594acc353d1784710ca32041c3ee269ab694..e3045031b3425128a06cfb95e27d685052569e1d 100644
--- a/content/browser/renderer_host/input/touch_selection_controller.h
+++ b/content/browser/renderer_host/input/touch_selection_controller.h
@@ -31,6 +31,7 @@ class CONTENT_EXPORT TouchSelectionControllerClient {
virtual bool SupportsAnimation() const = 0;
virtual void SetNeedsAnimate() = 0;
virtual void MoveCaret(const gfx::PointF& position) = 0;
+ virtual void MoveSelectionExtent(const gfx::PointF& position) = 0;
virtual void SelectBetweenCoordinates(const gfx::PointF& start,
jdduke (slow) 2014/10/15 15:46:07 While you're digging around here, maybe we could r
christiank 2014/10/17 14:33:05 Sure, makes sense.
const gfx::PointF& end) = 0;
virtual void OnSelectionEvent(SelectionEventType event,
@@ -133,7 +134,6 @@ class CONTENT_EXPORT TouchSelectionController : public TouchHandleClient {
scoped_ptr<TouchHandle> start_selection_handle_;
scoped_ptr<TouchHandle> end_selection_handle_;
- gfx::PointF fixed_handle_position_;
bool is_selection_active_;
bool activate_selection_automatically_;

Powered by Google App Engine
This is Rietveld 408576698