Issue 657793002: Give simple types to Math.Min, Math.Max, Math.Fround, Math.Clz32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 657793002: Give simple types to Math.Min, Math.Max, Math.Fround, Math.Clz32. (Closed)

Created:
6 years, 2 months ago by neis

Modified:
6 years, 2 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Give simple types to Math.Min, Math.Max, Math.Fround, Math.Clz32. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24640

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -21 lines)			Patch
	M	src/compiler/typer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/compiler/typer.cc	View		2 chunks	+31 lines, -21 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM with comment https://codereview.chromium.org/657793002/diff/1/src/compiler/typer.cc File src/compiler/typer.cc (right): https://codereview.chromium.org/657793002/diff/1/src/compiler/typer.cc#newcode1539 src/compiler/typer.cc:1539: // TODO(rossberg): can't express overloading This ...

6 years, 2 months ago (2014-10-15 12:32:08 UTC) #2

neis

6 years, 2 months ago (2014-10-15 14:12:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24640 (presubmit successful).

Expand Messages | Collapse Messages