Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 657783003: mojo: Fix map of booleans for python bindings. (Closed)

Created:
6 years, 2 months ago by qsr
Modified:
6 years, 2 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Fix map of booleans for python bindings. Array of booleans must be packed. R=sdefresne@chromium.org Committed: https://crrev.com/c11b522db2a6157ab7cdcbd1f00b415420320a56 Cr-Commit-Position: refs/heads/master@{#299668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M mojo/public/python/mojo/bindings/descriptor.py View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
qsr
6 years, 2 months ago (2014-10-15 07:48:56 UTC) #1
sdefresne
Can you add unit tests?
6 years, 2 months ago (2014-10-15 09:13:12 UTC) #2
qsr
On 2014/10/15 09:13:12, sdefresne wrote: > Can you add unit tests? Hum... Not as easily ...
6 years, 2 months ago (2014-10-15 09:17:24 UTC) #3
qsr
6 years, 2 months ago (2014-10-15 09:17:30 UTC) #4
sdefresne
lgtm https://memegen.googleplex.com/5877649
6 years, 2 months ago (2014-10-15 09:35:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657783003/1
6 years, 2 months ago (2014-10-15 09:52:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 10:10:30 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 10:11:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c11b522db2a6157ab7cdcbd1f00b415420320a56
Cr-Commit-Position: refs/heads/master@{#299668}

Powered by Google App Engine
This is Rietveld 408576698