Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 657783002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
Nicolas Zea, pavely
CC:
chromium-reviews, maniscalco+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/494aa0ac24d13bdc01d6ebc716f3a3d8314a344a Cr-Commit-Position: refs/heads/master@{#299978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -22 lines) Patch
M sync/engine/directory_commit_contributor.cc View 1 chunk +1 line, -4 lines 0 comments Download
M sync/engine/get_updates_processor_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M sync/engine/sync_scheduler_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M sync/internal_api/attachments/attachment_service_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/attachments/attachment_uploader_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/attachments/task_queue_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/sessions/nudge_tracker_unittest.cc View 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
6 years, 2 months ago (2014-10-15 17:13:18 UTC) #2
dcheng
+pavely, mind taking a look?
6 years, 2 months ago (2014-10-16 18:02:40 UTC) #4
pavely
lgtm
6 years, 2 months ago (2014-10-16 21:14:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657783002/1
6 years, 2 months ago (2014-10-16 21:16:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 21:37:54 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 21:38:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/494aa0ac24d13bdc01d6ebc716f3a3d8314a344a
Cr-Commit-Position: refs/heads/master@{#299978}

Powered by Google App Engine
This is Rietveld 408576698