Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 657753002: Remove state variables in PumpSession as they are no longer used. (Closed)

Created:
6 years, 2 months ago by kouhei (in TOK)
Modified:
6 years, 2 months ago
Reviewers:
haraken, tasak, eseidel
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove state variables in PumpSession as they are no longer used. This CL removes member variables of PumpSession, as they are no longer used. Since r183572, all asynchronous parsing uses background thread and these state variables were only used for deprecated asynchronous main thread parsing. BUG=421189 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183728

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -34 lines) Patch
M Source/core/html/parser/HTMLDocumentParser.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 3 chunks +2 lines, -9 lines 0 comments Download
M Source/core/html/parser/HTMLParserScheduler.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/html/parser/HTMLParserScheduler.cpp View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kouhei (in TOK)
Refactoring. Dead code removals only.
6 years, 2 months ago (2014-10-15 04:26:47 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-15 04:30:12 UTC) #3
tasak
lgtm
6 years, 2 months ago (2014-10-15 05:19:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657753002/20001
6 years, 2 months ago (2014-10-15 07:47:10 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 08:49:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183728

Powered by Google App Engine
This is Rietveld 408576698