Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 657723002: Add a runtime enabled feature for Service Workers' Cache API. (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
Reviewers:
haraken, nhiroki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, mkwst+moarreviews_chromium.org, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add a runtime enabled feature for Service Workers' Cache API. Service Workers' Cache API lets authors to fully manage their content caches for offline use. https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache-objects But Service Worker is planned to be shipped without this API for the first launch. So we add its own runtime enabled feature. BUG=423601 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/modules/serviceworkers/Cache.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/CacheStorage.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
horo
nhiroki@ Could you please review this?
6 years, 2 months ago (2014-10-15 03:06:46 UTC) #2
nhiroki
lgtm
6 years, 2 months ago (2014-10-15 03:19:51 UTC) #3
horo
haraken@ Could you please review Source/platform/RuntimeEnabledFeatures.in?
6 years, 2 months ago (2014-10-15 03:48:41 UTC) #5
haraken
LGTM for platform/.
6 years, 2 months ago (2014-10-15 03:52:22 UTC) #6
horo
On 2014/10/15 03:52:22, haraken wrote: > LGTM for platform/. Thank you!
6 years, 2 months ago (2014-10-15 04:35:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657723002/1
6 years, 2 months ago (2014-10-15 04:36:14 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 04:39:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183718

Powered by Google App Engine
This is Rietveld 408576698