Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 657693002: Move request_queue/_impl to //extensions (Closed)

Created:
6 years, 2 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@download-manifest-url-handler
Project:
chromium
Visibility:
Public.

Description

Move request_queue/_impl to //extensions BUG=398671 Committed: https://crrev.com/568502632b4e42a143bbe713c08e7a7aba221d5a Cr-Commit-Position: refs/heads/master@{#299757}

Patch Set 1 #

Patch Set 2 : merge up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -358 lines) Patch
M chrome/browser/extensions/updater/extension_downloader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/updater/request_queue.h View 1 chunk +0 lines, -147 lines 0 comments Download
D chrome/browser/extensions/updater/request_queue_impl.h View 1 chunk +0 lines, -154 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/browser/updater/request_queue.h View 5 chunks +8 lines, -13 lines 0 comments Download
A + extensions/browser/updater/request_queue_impl.h View 6 chunks +39 lines, -39 lines 0 comments Download
M extensions/extensions.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ken Rockot(use gerrit already)
ptal - super simple, mechanical change. also applied standard formatting to the template code while ...
6 years, 2 months ago (2014-10-14 21:28:42 UTC) #2
asargent_no_longer_on_chrome
lgtm
6 years, 2 months ago (2014-10-15 18:18:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657693002/1
6 years, 2 months ago (2014-10-15 19:09:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657693002/20001
6 years, 2 months ago (2014-10-15 19:18:51 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-15 20:29:46 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 20:31:33 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/568502632b4e42a143bbe713c08e7a7aba221d5a
Cr-Commit-Position: refs/heads/master@{#299757}

Powered by Google App Engine
This is Rietveld 408576698