Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Unified Diff: sdk/lib/_internal/pub_generated/test/transformer/loads_different_configurations_from_the_same_isolate_test.dart

Issue 657673002: Regenerate pub sources. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub_generated/test/transformer/loads_different_configurations_from_the_same_isolate_test.dart
diff --git a/sdk/lib/_internal/pub_generated/test/transformer/loads_different_configurations_from_the_same_isolate_test.dart b/sdk/lib/_internal/pub_generated/test/transformer/loads_different_configurations_from_the_same_isolate_test.dart
index bb6443053b69d6272f870adadfc0b85a40e76cc4..fc285095723399a27058420cd3444c1a8feed6a0 100644
--- a/sdk/lib/_internal/pub_generated/test/transformer/loads_different_configurations_from_the_same_isolate_test.dart
+++ b/sdk/lib/_internal/pub_generated/test/transformer/loads_different_configurations_from_the_same_isolate_test.dart
@@ -1,11 +1,34 @@
+// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS d.file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
library pub_tests;
+
import '../descriptor.dart' as d;
import '../test_pub.dart';
import '../serve/utils.dart';
+
main() {
initConfig();
withBarbackVersions("any", () {
integration("loads different configurations from the same isolate", () {
+ // If different configurations are loaded from different isolates, a
+ // transformer can end up being loaded twice. It's even possible for the
+ // second load to use code that's transformed by the first, which is
+ // really bad. This tests sets up such a scenario.
+ //
+ // The foo package has two self-transformers: foo/first and foo/second,
+ // loaded in that order. This means that *no instances of foo/first*
+ // should ever have their code transformed by foo/second.
+ //
+ // The myapp package also has a reference to foo/first. This reference has
+ // a different configuration than foo's, which means that if it's loaded
+ // in a separate isolate, it will be loaded after all of foo's
+ // transformers have run. This means that foo/first.dart will have been
+ // transformed by foo/first and foo/second, causing it to have different
+ // code than the previous instance. This tests asserts that that doesn't
+ // happen.
+
d.dir("foo", [d.pubspec({
"name": "foo",
"version": "1.0.0",
@@ -20,6 +43,7 @@ main() {
[
d.file("first.dart", dartTransformer('foo/first')),
d.file("second.dart", dartTransformer('foo/second'))])]).create();
+
d.dir(appPath, [d.pubspec({
"name": "myapp",
"transformers": [{
@@ -38,19 +62,28 @@ main() {
}
}
}),
- d.dir(
- "web",
- [
- d.file("first.dart", 'const TOKEN = "myapp/first";'),
- d.file("second.dart", 'const TOKEN = "myapp/second";')])]).create();
+ d.dir("web", [// This is transformed by foo/first. It's used to see which
+ // transformers ran on foo/first.
+ d.file("first.dart", 'const TOKEN = "myapp/first";'),
+ // This is transformed by foo/second. It's used to see which
+ // transformers ran on foo/second.
+ d.file("second.dart", 'const TOKEN = "myapp/second";')])]).create();
+
createLockFile('myapp', sandbox: ['foo'], pkg: ['barback']);
+
pubServe();
+
+ // The version of foo/first used on myapp should have myapp's
+ // configuration and shouldn't be transformed by foo/second.
requestShouldSucceed(
"first.dart",
'const TOKEN = "(myapp/first, foo/first in myapp)";');
+
+ // foo/second should be transformed by only foo/first.
requestShouldSucceed(
"second.dart",
'const TOKEN = "(myapp/second, (foo/second, foo/first in foo))";');
+
endPubServe();
});
});

Powered by Google App Engine
This is Rietveld 408576698