Move app list search box into AppListView.

Move app list search box into AppListView.

This CL moves the app list search box from AppListMainView into
AppListView. This sets up work for animating the start page
search box.

As a consequence, the ContentsView has been expanded to take up
the space previously consumed by the SearchBoxView's layout.

Some padding positions have changed in both app lists but the
overall app list dimensions remain unchanged.

BUG=425444
Committed: https://crrev.com/471e8f633105e7108fa9dcaebf38d304f002a8a9
Cr-Commit-Position: refs/heads/master@{#301308}

[calamity, 2014-10-23 04:43:31]

Patchset #1 (id:1) has been deleted

[calamity, 2014-10-23 05:28:43]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[calamity, 2014-10-23 05:28:59]

calamity@chromium.org changed required reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2014-10-24 03:21:40]

lgtm with nits.

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/app_li...
File ui/app_list/views/app_list_view_unittest.cc (right):

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view_unittest.cc:489: const gfx::Rect
active_contents_bounds =
Why not "default_contents_bounds"?

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/conten...
File ui/app_list/views/contents_view.cc (right):

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/conten...
ui/app_list/views/contents_view.cc:217: gfx::Rect
on_screen(GetDefaultContentsBounds());
like it.

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/conten...
ui/app_list/views/contents_view.cc:301: return gfx::Size(
default_contents_bounds.Union(search_box_bounds);
return gfx::Size(default_contents_bounds.right(),
                 default_contents_bounds.bottom());

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/conten...
File ui/app_list/views/contents_view.h (right):

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/conten...
ui/app_list/views/contents_view.h:110: // Returns the default bounds of the
search box.
I don't like the use of the word "default" in these comments. (They are
completely redundant for the method name.) Explain what it is in each case.

So in this case it's the bounds of the search box at the top of the page (when
not on the start page).

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/conten...
ui/app_list/views/contents_view.h:113: // Returns the bounds of the default
content area.
This is the bounds of the main area under the search box. (Maybe explain here
that the contents bounds fills up the entire window; this method just gives you
a guide as to where the user-interactable content should go.)

[calamity, 2014-10-24 06:13:08]

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/app_li...
File ui/app_list/views/app_list_view_unittest.cc (right):

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view_unittest.cc:489: const gfx::Rect
active_contents_bounds =
On 2014/10/24 03:21:40, Matt Giuca wrote:
> Why not "default_contents_bounds"?

Done.

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/conten...
File ui/app_list/views/contents_view.cc (right):

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/conten...
ui/app_list/views/contents_view.cc:217: gfx::Rect
on_screen(GetDefaultContentsBounds());
On 2014/10/24 03:21:40, Matt Giuca wrote:
> like it.

Acknowledged.

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/conten...
ui/app_list/views/contents_view.cc:301: return gfx::Size(
On 2014/10/24 03:21:40, Matt Giuca wrote:
> default_contents_bounds.Union(search_box_bounds);
> return gfx::Size(default_contents_bounds.right(),
>                  default_contents_bounds.bottom());

Nope. search_box_bounds doesn't have 0, 0 origin.

I can _make_ it have 0, 0 origin but I actually did this to begin with but it's
kinda gross semantically. I think this best expresses what's going on here (make
the size the biggest x/y coordinates of these areas).

Maybe I can use some other classes to do some of this for me.

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/conten...
File ui/app_list/views/contents_view.h (right):

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/conten...
ui/app_list/views/contents_view.h:110: // Returns the default bounds of the
search box.
On 2014/10/24 03:21:40, Matt Giuca wrote:
> I don't like the use of the word "default" in these comments. (They are
> completely redundant for the method name.) Explain what it is in each case.
> 
> So in this case it's the bounds of the search box at the top of the page (when
> not on the start page).

They're default because they will be customized by any of the actual content
views. I'd be confused by GetSearchBoxBounds() != search_box_view_->bounds();

https://codereview.chromium.org/657653002/diff/40001/ui/app_list/views/conten...
ui/app_list/views/contents_view.h:113: // Returns the bounds of the default
content area.
On 2014/10/24 03:21:40, Matt Giuca wrote:
> This is the bounds of the main area under the search box. (Maybe explain here
Done.
> that the contents bounds fills up the entire window; this method just gives
you
> a guide as to where the user-interactable content should go.)
Eh. This isn't particularly true. It's just where you should go if you don't
want to be special..

[calamity, 2014-10-24 06:13:26]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-10-24 06:14:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657653002/60001

[calamity, 2014-10-24 06:14:49]

The CQ bit was unchecked by calamity@chromium.org

[calamity, 2014-10-26 23:47:26]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-10-26 23:48:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657653002/60001

[commit-bot: I haz the power, 2014-10-26 23:50:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-26 23:50:49]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/73716)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[calamity, 2014-10-27 01:53:01]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-10-27 01:54:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657653002/100001

[commit-bot: I haz the power, 2014-10-27 02:34:39]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2014-10-27 02:35:13]

Patchset 5 (id:??) landed as
https://crrev.com/471e8f633105e7108fa9dcaebf38d304f002a8a9
Cr-Commit-Position: refs/heads/master@{#301308}