Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Issue 657643003: Cleanup: Remove unneeded extensions #includes. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 2 months ago
CC:
chromium-reviews, asanka, skanuj+watch_chromium.org, zea+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, rginda+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, melevin+watch_chromium.org, benjhayden+dwatch_chromium.org, pvalenzuela+watch_chromium.org, chromium-apps-reviews_chromium.org, yoshiki+watch_chromium.org, jfweitz+watch_chromium.org, Jered, maniscalco+watch_chromium.org, tfarina, donnd+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unneeded extensions #includes. Also put some extensions #includes behind ENABLE_EXTENSIONS. Committed: https://crrev.com/ceb89f23e5b89463295bdca9d8b2babaa4e26a1e Cr-Commit-Position: refs/heads/master@{#300168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M chrome/browser/bookmarks/enhanced_bookmarks_features.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_item_model_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/external_component_loader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_tab_delegate_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_instant_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
There's a couple downloads file here. Hope you don't mind reviewing the whole thing. It's ...
6 years, 2 months ago (2014-10-17 18:57:42 UTC) #2
Randy Smith (Not in Mondays)
So, just to be clear, I'm not an expert on extensions. Having said that, I ...
6 years, 2 months ago (2014-10-17 19:43:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657643003/1
6 years, 2 months ago (2014-10-17 21:27:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 22:00:03 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 22:01:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ceb89f23e5b89463295bdca9d8b2babaa4e26a1e
Cr-Commit-Position: refs/heads/master@{#300168}

Powered by Google App Engine
This is Rietveld 408576698