Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: runtime/vm/intermediate_language.h

Issue 657613004: VM: Avoid repeated deoptimization on speculatively hoisted smi-checks. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 41117)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -4588,9 +4588,8 @@
class CheckEitherNonSmiInstr : public TemplateInstruction<2> {
public:
- CheckEitherNonSmiInstr(Value* left,
- Value* right,
- intptr_t deopt_id) {
+ CheckEitherNonSmiInstr(Value* left, Value* right, intptr_t deopt_id)
+ : licm_hoisted_(false) {
SetInputAt(0, left);
SetInputAt(1, right);
// Override generated deopt-id.
@@ -4615,7 +4614,11 @@
virtual bool MayThrow() const { return false; }
+ void set_licm_hoisted(bool value) { licm_hoisted_ = value; }
+
private:
+ bool licm_hoisted_;
+
DISALLOW_COPY_AND_ASSIGN(CheckEitherNonSmiInstr);
};
@@ -7862,7 +7865,7 @@
class CheckSmiInstr : public TemplateInstruction<1> {
public:
CheckSmiInstr(Value* value, intptr_t original_deopt_id, intptr_t token_pos)
- : token_pos_(token_pos) {
+ : token_pos_(token_pos), licm_hoisted_(false) {
SetInputAt(0, value);
deopt_id_ = original_deopt_id;
}
@@ -7885,8 +7888,11 @@
virtual bool MayThrow() const { return false; }
+ void set_licm_hoisted(bool value) { licm_hoisted_ = value; }
+
private:
const intptr_t token_pos_;
+ bool licm_hoisted_;
DISALLOW_COPY_AND_ASSIGN(CheckSmiInstr);
};
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698