Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 657613004: VM: Avoid repeated deoptimization on speculatively hoisted smi-checks. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 3529 matching lines...) Expand 10 before | Expand all | Expand 10 after
3540 LocationSummary* summary = new(isolate) LocationSummary( 3540 LocationSummary* summary = new(isolate) LocationSummary(
3541 isolate, kNumInputs, kNumTemps, LocationSummary::kNoCall); 3541 isolate, kNumInputs, kNumTemps, LocationSummary::kNoCall);
3542 summary->set_in(0, Location::RequiresRegister()); 3542 summary->set_in(0, Location::RequiresRegister());
3543 summary->set_in(1, Location::RequiresRegister()); 3543 summary->set_in(1, Location::RequiresRegister());
3544 return summary; 3544 return summary;
3545 } 3545 }
3546 3546
3547 3547
3548 void CheckEitherNonSmiInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 3548 void CheckEitherNonSmiInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
3549 Label* deopt = compiler->AddDeoptStub(deopt_id(), 3549 Label* deopt = compiler->AddDeoptStub(deopt_id(),
3550 ICData::kDeoptBinaryDoubleOp); 3550 ICData::kDeoptBinaryDoubleOp,
3551 licm_hoisted_ ? ICData::kHoisted : 0);
3551 intptr_t left_cid = left()->Type()->ToCid(); 3552 intptr_t left_cid = left()->Type()->ToCid();
3552 intptr_t right_cid = right()->Type()->ToCid(); 3553 intptr_t right_cid = right()->Type()->ToCid();
3553 const Register left = locs()->in(0).reg(); 3554 const Register left = locs()->in(0).reg();
3554 const Register right = locs()->in(1).reg(); 3555 const Register right = locs()->in(1).reg();
3555 if (this->left()->definition() == this->right()->definition()) { 3556 if (this->left()->definition() == this->right()->definition()) {
3556 __ tst(left, Operand(kSmiTagMask)); 3557 __ tst(left, Operand(kSmiTagMask));
3557 } else if (left_cid == kSmiCid) { 3558 } else if (left_cid == kSmiCid) {
3558 __ tst(right, Operand(kSmiTagMask)); 3559 __ tst(right, Operand(kSmiTagMask));
3559 } else if (right_cid == kSmiCid) { 3560 } else if (right_cid == kSmiCid) {
3560 __ tst(left, Operand(kSmiTagMask)); 3561 __ tst(left, Operand(kSmiTagMask));
(...skipping 2322 matching lines...) Expand 10 before | Expand all | Expand 10 after
5883 const intptr_t kNumTemps = 0; 5884 const intptr_t kNumTemps = 0;
5884 LocationSummary* summary = new(isolate) LocationSummary( 5885 LocationSummary* summary = new(isolate) LocationSummary(
5885 isolate, kNumInputs, kNumTemps, LocationSummary::kNoCall); 5886 isolate, kNumInputs, kNumTemps, LocationSummary::kNoCall);
5886 summary->set_in(0, Location::RequiresRegister()); 5887 summary->set_in(0, Location::RequiresRegister());
5887 return summary; 5888 return summary;
5888 } 5889 }
5889 5890
5890 5891
5891 void CheckSmiInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 5892 void CheckSmiInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
5892 const Register value = locs()->in(0).reg(); 5893 const Register value = locs()->in(0).reg();
5893 Label* deopt = compiler->AddDeoptStub(deopt_id(), ICData::kDeoptCheckSmi); 5894 Label* deopt = compiler->AddDeoptStub(deopt_id(),
5895 ICData::kDeoptCheckSmi,
5896 licm_hoisted_ ? ICData::kHoisted : 0);
5894 __ tst(value, Operand(kSmiTagMask)); 5897 __ tst(value, Operand(kSmiTagMask));
5895 __ b(deopt, NE); 5898 __ b(deopt, NE);
5896 } 5899 }
5897 5900
5898 5901
5899 LocationSummary* CheckClassIdInstr::MakeLocationSummary(Isolate* isolate, 5902 LocationSummary* CheckClassIdInstr::MakeLocationSummary(Isolate* isolate,
5900 bool opt) const { 5903 bool opt) const {
5901 const intptr_t kNumInputs = 1; 5904 const intptr_t kNumInputs = 1;
5902 const intptr_t kNumTemps = 0; 5905 const intptr_t kNumTemps = 0;
5903 LocationSummary* summary = new(isolate) LocationSummary( 5906 LocationSummary* summary = new(isolate) LocationSummary(
(...skipping 1101 matching lines...) Expand 10 before | Expand all | Expand 10 after
7005 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs()); 7008 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());
7006 #if defined(DEBUG) 7009 #if defined(DEBUG)
7007 __ LoadImmediate(R4, kInvalidObjectPointer); 7010 __ LoadImmediate(R4, kInvalidObjectPointer);
7008 __ LoadImmediate(R5, kInvalidObjectPointer); 7011 __ LoadImmediate(R5, kInvalidObjectPointer);
7009 #endif 7012 #endif
7010 } 7013 }
7011 7014
7012 } // namespace dart 7015 } // namespace dart
7013 7016
7014 #endif // defined TARGET_ARCH_ARM 7017 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698