RenderHostImpl::AddRoute - Turn a DCHECK to CHECK()

content/browser/renderer_host/render_process_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 
 #include <algorithm>
@@ skipping 903 matching lines @@
 }
 
 ServiceRegistry* RenderProcessHostImpl::GetServiceRegistry() {
   DCHECK(mojo_application_host_);
   return mojo_application_host_->service_registry();
 }
 
 void RenderProcessHostImpl::AddRoute(
     int32 routing_id,
     IPC::Listener* listener) {
-  DCHECK(widget_helper_->IsRoutingIDProbablyValid(routing_id))
+  CHECK(widget_helper_->IsRoutingIDProbablyValid(routing_id))
       << "Found Routing ID conflicts: " << routing_id;

[nasko, 2014/10/14 18:49:33]

Should we add the previous CHECK we had too? I know the probability of this
failing without actually adding a duplicate is very low, but with the number of
users running the code you never know.

Also, let's log some more data (the RPH id, OS process id), so we have more to
look at in the crash reports.

[Hajime Morrita, 2014/10/14 19:36:55]

I worried to get as many crashes as before but true, we need it.
Added.
Add PID. Do we have log meessage in our crash report?
I wasn't aware of that. Could you point me where I can see it?

If we can see the dying message, we can do more. Not in this CL
but I'm thinking about passing base::Location from the caller
to AddRoute(). 

[nasko, 2014/10/14 20:54:16]

That's fine, at least we will know the relative amount of one type of crash vs
the other type.
 
Unfortunately we don't. We can use debug::Alias to ensure values we want to know
are on the stack and we can examine them.
It will be nice to add base::Location, but AddRoute is a public interface method
and changing it doesn't seem right for a temp change to collect debug stats.

   listeners_.AddWithID(listener, routing_id);
 }
 
 void RenderProcessHostImpl::RemoveRoute(int32 routing_id) {
   DCHECK(listeners_.Lookup(routing_id) != NULL);
   listeners_.Remove(routing_id);
 
 #if defined(OS_WIN)
   // Dump the handle table if handle auditing is enabled.
   const base::CommandLine& browser_command_line =
@@ skipping 1316 matching lines @@
   if (worker_ref_count_ == 0)
     Cleanup();
 }
 
 void RenderProcessHostImpl::EnsureMojoActivated() {
   mojo_activation_required_ = true;
   MaybeActivateMojo();
 }
 
 }  // namespace content