chrome/browser/chrome_browser_main.cc - Issue 657613002: Certificate Transparency: EV certificates whitelist support for ChromeOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 657613002: Certificate Transparency: EV certificates whitelist support for ChromeOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ev_list_unpacking_redo

Patch Set: Adding missing include Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/login/session/user_session_manager.h » ('j') | chrome/browser/chromeos/login/session/user_session_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_browser_main.cc

diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc

index 271eb2205c2b95004c9883ea4e3aa58008905b58..35e26f7b60204b09d315c55f6b306c38ce81c95e 100644

--- a/chrome/browser/chrome_browser_main.cc

+++ b/chrome/browser/chrome_browser_main.cc

@@ -431,15 +431,13 @@ void RegisterComponentsForUpdate() {

// network.

// For Chrome OS this registration is delayed until user login.

g_browser_process->crl_set_fetcher()->StartInitialLoad(cus, path);

+ // Android does not currently have the EV indicator. No need to get the

Sorin Jianu 2014/11/07 17:30:44 Can you please clarify the comment?

Eran Messeri 2014/11/10 22:54:56 Done.

+ // EV certs whitelist on Android, then.

+ // For Chrome OS this registration is delayed until user login.

+ RegisterEVWhitelistComponent(cus, path);

#endif

}

-#if !defined(OS_ANDROID)

- // Android does not currently have the EV indicator. No need to get the

- // EV certs whitelist on Android, then.

- RegisterEVWhitelistComponent(cus);

-#endif

#if defined(OS_WIN)

RegisterSwReporterComponent(cus, g_browser_process->local_state());

#endif

« no previous file with comments | « no previous file | chrome/browser/chromeos/login/session/user_session_manager.h » ('j') | chrome/browser/chromeos/login/session/user_session_manager.h » ('J')