chrome/browser/net/packed_ct_ev_whitelist.h - Issue 657613002: Certificate Transparency: EV certificates whitelist support for ChromeOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/packed_ct_ev_whitelist.h

Issue 657613002: Certificate Transparency: EV certificates whitelist support for ChromeOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ev_list_unpacking_redo

Patch Set: Addressing review comments (comment & formatting) Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/ev_whitelist_component_installer.cc ('k') | chrome/browser/net/packed_ct_ev_whitelist.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/packed_ct_ev_whitelist.h

diff --git a/chrome/browser/net/packed_ct_ev_whitelist.h b/chrome/browser/net/packed_ct_ev_whitelist.h

index db731bb75838870bcce5ca8eaf4c03ac477668a8..6cbc545053861c3f3652acac78dffd3a61308ec3 100644

--- a/chrome/browser/net/packed_ct_ev_whitelist.h

+++ b/chrome/browser/net/packed_ct_ev_whitelist.h

@@ -71,13 +71,9 @@ class PackedEVCertsWhitelist : public net::ct::EVCertsWhitelist {

DISALLOW_COPY_AND_ASSIGN(PackedEVCertsWhitelist);

};

-// Sets the EV certificate hashes whitelist from |compressed_whitelist_file|

-// in |ssl_config_service|, after uncompressing it.

-// If the data in |compressed_whitelist_file| is not a valid compressed

-// whitelist, does nothing.

-// As this function performs file operations, it should be called from a

-// blocking pool worker or a file worker.

+// Sets the EV certificate hashes whitelist in the SSLConfigService

+// to the provided |whitelist|, if valid. Otherwise, does nothing.

// To set the new whitelist, this function dispatches a task to the IO thread.

-void SetEVWhitelistFromFile(const base::FilePath& compressed_whitelist_file);

+void SetEVCertsWhitelist(scoped_refptr<net::ct::EVCertsWhitelist> whitelist);

#endif // CHROME_BROWSER_NET_PACKED_CT_EV_WHITELIST_H_