chrome/browser/net/packed_ct_ev_whitelist.h - Issue 657613002: Certificate Transparency: EV certificates whitelist support for ChromeOS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/net/packed_ct_ev_whitelist.h

Issue 657613002: Certificate Transparency: EV certificates whitelist support for ChromeOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ev_list_unpacking_redo

Patch Set: Addressed comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/component_updater/ev_whitelist_component_installer.cc ('K') | « chrome/browser/component_updater/ev_whitelist_component_installer.cc ('k') | chrome/browser/net/packed_ct_ev_whitelist.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_NET_PACKED_CT_EV_WHITELIST_H_	5 #ifndef CHROME_BROWSER_NET_PACKED_CT_EV_WHITELIST_H_

6 #define CHROME_BROWSER_NET_PACKED_CT_EV_WHITELIST_H_	6 #define CHROME_BROWSER_NET_PACKED_CT_EV_WHITELIST_H_

7	7

8 #include <stdint.h>	8 #include <stdint.h>

9	9

10 #include <string>	10 #include <string>

(...skipping 62 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 DISALLOW_COPY_AND_ASSIGN(PackedEVCertsWhitelist);	73 DISALLOW_COPY_AND_ASSIGN(PackedEVCertsWhitelist);

74 };	74 };

75	75

76 // Sets the EV certificate hashes whitelist from \|compressed_whitelist_file\|	76 // Sets the EV certificate hashes whitelist from \|compressed_whitelist_file\|

77 // in \|ssl_config_service\|, after uncompressing it.	77 // in \|ssl_config_service\|, after uncompressing it.

78 // If the data in \|compressed_whitelist_file\| is not a valid compressed	78 // If the data in \|compressed_whitelist_file\| is not a valid compressed

79 // whitelist, does nothing.	79 // whitelist, does nothing.

80 // As this function performs file operations, it should be called from a	80 // As this function performs file operations, it should be called from a

81 // blocking pool worker or a file worker.	81 // blocking pool worker or a file worker.

82 // To set the new whitelist, this function dispatches a task to the IO thread.	82 // To set the new whitelist, this function dispatches a task to the IO thread.

83 void SetEVWhitelistFromFile(const base::FilePath& compressed_whitelist_file);	83 void SetEVCertsWhitelist(

	84 scoped_refptr<net::ct::EVCertsWhitelist> new_whitelist);
	Sorin Jianu 2014/11/11 20:09:28 I think we can avoid the new_ prefix for the name I think we can avoid the new_ prefix for the name of the function parameter as well. Eran Messeri 2014/11/20 17:55:05 Done. Show quoted text On 2014/11/11 20:09:28, Sorin Jianu wrote: > I think we can avoid the new_ prefix for the name of the function parameter as > well. Done.
84	85

85 #endif // CHROME_BROWSER_NET_PACKED_CT_EV_WHITELIST_H_	86 #endif // CHROME_BROWSER_NET_PACKED_CT_EV_WHITELIST_H_

OLD	NEW