Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/gpu/gpu_watchdog_thread.cc

Issue 6576044: Renamed GpuWatchdogThread::OnExit to make it clear it is crashing deliberatel... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/gpu/gpu_watchdog_thread.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/gpu/gpu_watchdog_thread.cc
===================================================================
--- chrome/gpu/gpu_watchdog_thread.cc (revision 75942)
+++ chrome/gpu/gpu_watchdog_thread.cc (working copy)
@@ -118,7 +118,7 @@
if (!armed_)
return;
- // Revoke any pending OnExit.
+ // Revoke any pending hang termination.
method_factory_->RevokeAll();
armed_ = false;
@@ -188,12 +188,13 @@
// not respond in time.
message_loop()->PostDelayedTask(
FROM_HERE,
- method_factory_->NewRunnableMethod(&GpuWatchdogThread::OnExit),
+ method_factory_->NewRunnableMethod(
+ &GpuWatchdogThread::DeliberatelyCrashingToRecoverFromHang),
timeout_);
}
// Use the --disable-gpu-watchdog command line switch to disable this.
-void GpuWatchdogThread::OnExit() {
+void GpuWatchdogThread::DeliberatelyCrashingToRecoverFromHang() {
#if defined(OS_WIN)
// Defer termination until a certain amount of CPU time has elapsed on the
// watched thread.
@@ -201,7 +202,8 @@
if (time_since_arm < timeout_) {
message_loop()->PostDelayedTask(
FROM_HERE,
- method_factory_->NewRunnableMethod(&GpuWatchdogThread::OnExit),
+ method_factory_->NewRunnableMethod(
+ &GpuWatchdogThread::DeliberatelyCrashingToRecoverFromHang),
timeout_ - time_since_arm);
return;
}
« no previous file with comments | « chrome/gpu/gpu_watchdog_thread.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698