Renamed GpuWatchdogThread::OnExit to make it clear it is crashing deliberatel...

Renamed GpuWatchdogThread::OnExit to make it clear it is crashing deliberately.

It crashes rather than exiting normally so that the hang is reported as a crash and it is possible to see what the presumed hung thread was doing in order to diagnose whether or not there is a bug.

TEST=try
BUG=73871
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76106

[Avi (use Gerrit), 2011-02-24 19:15:43]

http://codereview.chromium.org/6576044/diff/1/chrome/gpu/gpu_watchdog_thread.cc
File chrome/gpu/gpu_watchdog_thread.cc (right):

http://codereview.chromium.org/6576044/diff/1/chrome/gpu/gpu_watchdog_thread....
chrome/gpu/gpu_watchdog_thread.cc:199:
DeliberatelyCrashingToRecoverFromHangNotNecessarilyABug() {
Awesome name!

[Scott Hess - ex-Googler, 2011-02-24 19:27:41]

http://codereview.chromium.org/6576044/diff/1/chrome/gpu/gpu_watchdog_thread.cc
File chrome/gpu/gpu_watchdog_thread.cc (right):

http://codereview.chromium.org/6576044/diff/1/chrome/gpu/gpu_watchdog_thread....
chrome/gpu/gpu_watchdog_thread.cc:199:
DeliberatelyCrashingToRecoverFromHangNotNecessarilyABug() {
On 2011/02/24 19:15:43, Avi wrote:
> Awesome name!

+1.  Hope it doesn't break the crash server!

[apatrick_chromium, 2011-02-24 19:30:54]

Do I hear LGTM?

[Scott Hess - ex-Googler, 2011-02-24 20:52:47]

Hmm, LGTM in that it addresses my point on the bug.  But if I were actually
reviewing it I'd probably say to make the function more concise so the
formatting isn't weird.

[apatrick_chromium, 2011-02-24 21:05:36]

I made the function name shorter to avoid line breaks in weird places.

[vangelis, 2011-02-25 21:41:10]

nice name :)

LGTM

[Scott Hess - ex-Googler, 2011-02-25 21:47:29]

Oh, yes, LGTM too.  Sounds very responsible.

On Fri, Feb 25, 2011 at 1:41 PM,  <vangelis@google.com> wrote:
> nice name :)
>
> LGTM
>
> http://codereview.chromium.org/6576044/
>