Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 657603007: Initialize app_cache_host_ of EmbeddedSharedWorkerStub. (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
Reviewers:
falken
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Initialize app_cache_host_ of EmbeddedSharedWorkerStub. Currently it is not initialized. So when --disable-application-cache flag is set, a crash occurs while starting a SharedWorker. BUG=401259 Committed: https://crrev.com/2eaf42febdf0014e1175dedd7ce28e9ad9e11315 Cr-Commit-Position: refs/heads/master@{#299671}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use nullptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
horo
falken@ Could you please review?
6 years, 2 months ago (2014-10-15 06:11:48 UTC) #2
falken
lgtm with nit https://codereview.chromium.org/657603007/diff/1/content/renderer/shared_worker/embedded_shared_worker_stub.cc File content/renderer/shared_worker/embedded_shared_worker_stub.cc (right): https://codereview.chromium.org/657603007/diff/1/content/renderer/shared_worker/embedded_shared_worker_stub.cc#newcode68 content/renderer/shared_worker/embedded_shared_worker_stub.cc:68: app_cache_host_(NULL) { new code uses nullptr: ...
6 years, 2 months ago (2014-10-15 06:29:06 UTC) #3
horo
Thank you! https://codereview.chromium.org/657603007/diff/1/content/renderer/shared_worker/embedded_shared_worker_stub.cc File content/renderer/shared_worker/embedded_shared_worker_stub.cc (right): https://codereview.chromium.org/657603007/diff/1/content/renderer/shared_worker/embedded_shared_worker_stub.cc#newcode68 content/renderer/shared_worker/embedded_shared_worker_stub.cc:68: app_cache_host_(NULL) { On 2014/10/15 06:29:06, falken wrote: ...
6 years, 2 months ago (2014-10-15 07:05:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657603007/20001
6 years, 2 months ago (2014-10-15 10:06:28 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-15 10:40:39 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 10:41:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2eaf42febdf0014e1175dedd7ce28e9ad9e11315
Cr-Commit-Position: refs/heads/master@{#299671}

Powered by Google App Engine
This is Rietveld 408576698