|
|
Chromium Code Reviews|
Created:
6 years, 2 months ago by Sergiy Byelozyorov Modified:
6 years, 2 months ago CC:
ojan, blink-reviews, cbiesinger, dsinclair, jochen (gone - plz use gerrit), leviw_travelin_and_unemployed, michaelpg, szager1, teravest Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Project:
blink Visibility:
Public. |
DescriptionDecreased num alerts in history per page to 5 to avoid exceeding memory and response limit
R=machenbach@chromium.org,ojan@chromium.org
BUG=416182
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183738
Patch Set 1 #
Messages
Total messages: 19 (8 generated)
non-owner rubber-stamp lgtm - any issue number for this?
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657533002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657533002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657533002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)
ojan@chromium.org changed reviewers: + ojan@chromium.org
I didn't notice this in the original review. I think we should have two different pages here: 1. The alert json for a single alerts entry. 2. A list of alert jsons to pick from (not the actual content, just a list that a crawler can crawl through. We shouldn't have the thing we have here which is lumping a bunch of alert jsons into a single http request. In either case, this patch lgtm.
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657533002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183738 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
