Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp

Issue 657523002: Skip expensive hasInstance() type-checks in overloads (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: minor updates Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp b/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp
index f6f3c9bb048cb7ce3862cd7de789e1ef45d3f7e9..40c429d214b4c112d65352a53664fa8296cfb4ff 100644
--- a/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp
@@ -31,11 +31,14 @@ const WrapperTypeInfo& TestInterfaceConstructor4::s_wrapperTypeInfo = V8TestInte
namespace TestInterfaceConstructor4V8Internal {
-static void constructor1(const v8::FunctionCallbackInfo<v8::Value>& info)
+static void constructor1(const v8::FunctionCallbackInfo<v8::Value>& info, int typeCheckedArgumentIndex)
{
TestInterfaceConstructor4* testInterface4Arg;
{
- testInterface4Arg = V8TestInterfaceConstructor4::toImplWithTypeCheck(info.GetIsolate(), info[0]);
+ if (typeCheckedArgumentIndex == 0)
+ testInterface4Arg = V8TestInterfaceConstructor4::toImpl(v8::Handle<v8::Object>::Cast(info[0]));
+ else
+ testInterface4Arg = V8TestInterfaceConstructor4::toImplWithTypeCheck(info.GetIsolate(), info[0]);
}
RefPtr<TestInterfaceConstructor4> impl = TestInterfaceConstructor4::create(testInterface4Arg);
v8::Handle<v8::Object> wrapper = info.Holder();
@@ -43,7 +46,7 @@ static void constructor1(const v8::FunctionCallbackInfo<v8::Value>& info)
v8SetReturnValue(info, wrapper);
}
-static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info)
+static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info, int typeCheckedArgumentIndex)
{
ExceptionState exceptionState(ExceptionState::ConstructionContext, "TestInterfaceConstructor4", info.Holder(), info.GetIsolate());
V8StringResource<> scalarValueStringArg;
@@ -62,11 +65,11 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)
switch (std::min(1, info.Length())) {
case 1:
if (V8TestInterfaceConstructor4::hasInstance(info[0], info.GetIsolate())) {
- TestInterfaceConstructor4V8Internal::constructor1(info);
+ TestInterfaceConstructor4V8Internal::constructor1(info, 0);
return;
}
if (true) {
- TestInterfaceConstructor4V8Internal::constructor2(info);
+ TestInterfaceConstructor4V8Internal::constructor2(info, -1);
return;
}
break;

Powered by Google App Engine
This is Rietveld 408576698