Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp

Issue 657523002: Skip expensive hasInstance() type-checks in overloads (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp b/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp
index 16ff2cf2ba9fa1f2d660cd077be89ba44fa67fa6..0c1652d3eccee2ee02d989cda5429ae5020aaa70 100644
--- a/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp
@@ -32,7 +32,7 @@ const WrapperTypeInfo& TestInterfaceConstructor2::s_wrapperTypeInfo = V8TestInte
namespace TestInterfaceConstructor2V8Internal {
-static void constructor1(const v8::FunctionCallbackInfo<v8::Value>& info)
+static void constructor1(const v8::FunctionCallbackInfo<v8::Value>& info, int type_checked_argument_index)
{
V8StringResource<> stringArg;
{
@@ -44,7 +44,7 @@ static void constructor1(const v8::FunctionCallbackInfo<v8::Value>& info)
v8SetReturnValue(info, wrapper);
}
-static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info)
+static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info, int type_checked_argument_index)
{
Dictionary dictionaryArg;
{
@@ -60,7 +60,7 @@ static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info)
v8SetReturnValue(info, wrapper);
}
-static void constructor3(const v8::FunctionCallbackInfo<v8::Value>& info)
+static void constructor3(const v8::FunctionCallbackInfo<v8::Value>& info, int type_checked_argument_index)
{
ExceptionState exceptionState(ExceptionState::ConstructionContext, "TestInterfaceConstructor2", info.Holder(), info.GetIsolate());
Vector<Vector<String> > stringSequenceSequenceArg;
@@ -73,7 +73,7 @@ static void constructor3(const v8::FunctionCallbackInfo<v8::Value>& info)
v8SetReturnValue(info, wrapper);
}
-static void constructor4(const v8::FunctionCallbackInfo<v8::Value>& info)
+static void constructor4(const v8::FunctionCallbackInfo<v8::Value>& info, int type_checked_argument_index)
{
ExceptionState exceptionState(ExceptionState::ConstructionContext, "TestInterfaceConstructor2", info.Holder(), info.GetIsolate());
TestInterfaceEmpty* testInterfaceEmptyArg;
@@ -118,45 +118,45 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)
switch (std::min(6, info.Length())) {
case 1:
if (info[0]->IsArray()) {
- TestInterfaceConstructor2V8Internal::constructor3(info);
+ TestInterfaceConstructor2V8Internal::constructor3(info, 0);
return;
}
if (info[0]->IsObject()) {
- TestInterfaceConstructor2V8Internal::constructor2(info);
+ TestInterfaceConstructor2V8Internal::constructor2(info, 0);
return;
}
if (true) {
- TestInterfaceConstructor2V8Internal::constructor1(info);
+ TestInterfaceConstructor2V8Internal::constructor1(info, -1);
return;
}
break;
case 2:
if (true) {
- TestInterfaceConstructor2V8Internal::constructor4(info);
+ TestInterfaceConstructor2V8Internal::constructor4(info, -1);
return;
}
break;
case 3:
if (true) {
- TestInterfaceConstructor2V8Internal::constructor4(info);
+ TestInterfaceConstructor2V8Internal::constructor4(info, -1);
return;
}
break;
case 4:
if (true) {
- TestInterfaceConstructor2V8Internal::constructor4(info);
+ TestInterfaceConstructor2V8Internal::constructor4(info, -1);
return;
}
break;
case 5:
if (true) {
- TestInterfaceConstructor2V8Internal::constructor4(info);
+ TestInterfaceConstructor2V8Internal::constructor4(info, -1);
return;
}
break;
case 6:
if (true) {
- TestInterfaceConstructor2V8Internal::constructor4(info);
+ TestInterfaceConstructor2V8Internal::constructor4(info, -1);
return;
}
break;

Powered by Google App Engine
This is Rietveld 408576698