history: remove focus outline when using touch on mobile.

history: remove focus outline when using touch on mobile.

R=estade@chromium.org
BUG=421816
Committed: https://crrev.com/5b715332471125356fe3bc3c325d1be12ba3a9fd
Cr-Commit-Position: refs/heads/master@{#314337}

[Evan Stade, 2014-10-15 21:52:35]

lgtm

[Dan Beam, 2014-10-15 21:53:58]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-10-15 21:55:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657493003/1

[Evan Stade, 2014-10-15 21:56:08]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2014-10-15 21:56:27]

On 2014/10/15 21:55:12, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/657493003/1

what about for people who are using an external keyboard or a trackball like
they used to have on the g1? Is there still sufficient indication of focus for
them to do keyboard navigation?

[Evan Stade, 2014-10-15 22:04:44]

On 2014/10/15 21:56:27, Evan Stade wrote:
> On 2014/10/15 21:55:12, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/657493003/1
> 
> what about for people who are using an external keyboard or a trackball like
> they used to have on the g1? Is there still sufficient indication of focus for
> them to do keyboard navigation?

I think since the entry as a whole is focusable, we can remove focusability of
the things within the entry (rather than just hiding focus).

[Dan Beam, 2015-02-02 23:24:21]

Patchset #2 (id:20001) has been deleted

[Dan Beam, 2015-02-02 23:38:58]

On 2014/10/15 22:04:44, Evan Stade wrote:
> On 2014/10/15 21:56:27, Evan Stade wrote:
> > On 2014/10/15 21:55:12, I haz the power (commit-bot) wrote:
> > > CQ is trying da patch. Follow status at
> > >  https://chromium-cq-status.appspot.com/patch-status/657493003/1
> > 
> > what about for people who are using an external keyboard or a trackball like
> > they used to have on the g1? Is there still sufficient indication of focus
for
> > them to do keyboard navigation?
> 
> I think since the entry as a whole is focusable, we can remove focusability of
> the things within the entry (rather than just hiding focus).

if focusable controls are useful on desktop, i don't see why it's not on mobile.

wdyt about the updated patch?

https://codereview.chromium.org/657493003/diff/40001/ui/webui/resources/js/cr...
File ui/webui/resources/js/cr/ui/focus_outline_manager.js (right):

https://codereview.chromium.org/657493003/diff/40001/ui/webui/resources/js/cr...
ui/webui/resources/js/cr/ui/focus_outline_manager.js:61:
this.classList_.toggle(CLASS_NAME, visible);
not super-related but don't know when else this would happen

[Evan Stade, 2015-02-02 23:45:13]

lgtm

[Dan Beam, 2015-02-02 23:47:48]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-02-02 23:49:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657493003/40001

[commit-bot: I haz the power, 2015-02-03 01:50:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-03 01:50:18]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (None)

[Dan Beam, 2015-02-03 15:11:26]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-02-03 15:12:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657493003/40001

[commit-bot: I haz the power, 2015-02-03 15:13:54]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-02-03 15:15:12]

Patchset 2 (id:??) landed as
https://crrev.com/5b715332471125356fe3bc3c325d1be12ba3a9fd
Cr-Commit-Position: refs/heads/master@{#314337}