Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 657493002: Use variadic templates in WTF::dataLog() (Closed)

Created:
6 years, 2 months ago by Mikhail
Modified:
6 years, 2 months ago
CC:
aandrey+blink_chromium.org, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use variadic templates in WTF::dataLog() Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -75 lines) Patch
M Source/wtf/DataLog.h View 1 chunk +3 lines, -75 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Mikhail
PTAL
6 years, 2 months ago (2014-10-14 10:00:37 UTC) #2
Mike West
This is a pretty perfect use-case for variadic templates. LGTM. :)
6 years, 2 months ago (2014-10-14 11:43:33 UTC) #4
Mikhail
6 years, 2 months ago (2014-10-15 10:05:55 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-15 15:30:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657493002/1
6 years, 2 months ago (2014-10-16 07:03:19 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 08:46:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183793

Powered by Google App Engine
This is Rietveld 408576698