Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2869)

Unified Diff: chrome/chrome_shell.gypi

Issue 657443002: Turn Chrome Shell's AndroidManifest into a jinja2 template. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ignore import failure in pylint Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/shell/java/AndroidManifest.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_shell.gypi
diff --git a/chrome/chrome_shell.gypi b/chrome/chrome_shell.gypi
index 20a7aae4fac1d58b6ef94a4eeea0316d7ca6e453..e9fa8808ca3a951e5d6454f765f44bb2de5ea95f 100644
--- a/chrome/chrome_shell.gypi
+++ b/chrome/chrome_shell.gypi
@@ -83,6 +83,16 @@
],
},
{
+ # GN: //chrome/android:chrome_shell_manifest
+ 'target_name': 'chrome_shell_manifest',
+ 'type': 'none',
+ 'variables': {
+ 'jinja_inputs': ['android/shell/java/AndroidManifest.xml'],
+ 'jinja_output': '<(SHARED_INTERMEDIATE_DIR)/chrome_shell_manifest/AndroidManifest.xml',
+ },
+ 'includes': [ '../build/android/jinja_template.gypi' ],
+ },
+ {
# GN: //chrome/android:chrome_shell_apk
'target_name': 'chrome_shell_apk',
'type': 'none',
@@ -94,6 +104,7 @@
],
'variables': {
'apk_name': 'ChromeShell',
+ 'android_manifest_path': '<(SHARED_INTERMEDIATE_DIR)/chrome_shell_manifest/AndroidManifest.xml',
'native_lib_version_name': '<(version_full)',
'java_in_dir': 'android/shell/java',
'resource_dir': 'android/shell/res',
« no previous file with comments | « chrome/android/shell/java/AndroidManifest.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698