Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 657423004: Fixed the inconsistent behavior when touching/longtouching on different input fields.

Created:
6 years, 2 months ago by AKVT
Modified:
5 years, 1 month ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed the inconsistent behavior when touching/longtouching on different input fields. Currently when long pressing on empty input field, IME is not showing, but if already input is showing for different input field and long pressing on another empty input field, IME should show. This change corrects the IME showing status based on previous IME status.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 chunk +14 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
AKVT
@aurimas & jamesr PTAL
6 years, 2 months ago (2014-10-22 17:11:40 UTC) #2
AKVT
@aurimas PTAL
6 years, 2 months ago (2014-10-23 17:29:57 UTC) #3
aurimas (slooooooooow)
On 2014/10/23 17:29:57, AKV wrote: > @aurimas PTAL Is there a bug open for this? ...
6 years, 2 months ago (2014-10-24 23:43:05 UTC) #4
AKVT
On 2014/10/24 23:43:05, aurimas wrote: > On 2014/10/23 17:29:57, AKV wrote: > > @aurimas PTAL ...
6 years, 1 month ago (2014-10-27 17:29:18 UTC) #5
AKVT
On 2014/10/27 17:29:18, AKVT wrote: > On 2014/10/24 23:43:05, aurimas wrote: > > On 2014/10/23 ...
5 years, 5 months ago (2015-07-02 15:36:11 UTC) #7
AKVT
5 years, 5 months ago (2015-07-02 15:36:41 UTC) #9
It's correcting a state, rather than fixing an existing issue. @jamesr and
@aurimas can you please take another look ?

Powered by Google App Engine
This is Rietveld 408576698