Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 657423002: Add README.md file (Closed)

Created:
6 years, 2 months ago by mnaganov (inactive)
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add README.md file Add basic info. This file is automatically displayed on GitHub, and is kind of de-facto standard for project documentation. BUG=chromium:415466 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24731

Patch Set 1 #

Patch Set 2 : Wrap long lines #

Total comments: 2

Patch Set 3 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
A README.md View 1 2 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
mnaganov (inactive)
Hi Michael, Can you please take a look?
6 years, 2 months ago (2014-10-16 16:47:38 UTC) #2
mathias
+1 to adding a `README.md`! (An `.editorconfig` file would be nice as well, IMHO.) https://codereview.chromium.org/657423002/diff/20001/README.md ...
6 years, 2 months ago (2014-10-16 20:35:09 UTC) #4
Michael Achenbach
+ Danno and Jakob
6 years, 2 months ago (2014-10-17 07:36:37 UTC) #6
Jakob Kummerow
I'm not against adding a README.md. I am concerned, however, about adding yet another copy ...
6 years, 2 months ago (2014-10-17 07:56:48 UTC) #7
mnaganov (inactive)
Thanks for your comments! I have only left statements about V8 that would not change ...
6 years, 2 months ago (2014-10-20 09:48:00 UTC) #8
Jakob Kummerow
lgtm
6 years, 2 months ago (2014-10-20 11:03:31 UTC) #9
mnaganov (inactive)
6 years, 2 months ago (2014-10-20 11:37:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 24731.

Powered by Google App Engine
This is Rietveld 408576698