Chromium Code Reviews

Issue 657413002: MIPS: Eliminate special keyed load string stub in favor of uniform handlers. (Closed)

Created:
6 years, 2 months ago by balazs.kilvady
Modified:
6 years, 2 months ago
Reviewers:
dusmil.imgtec, danno, mvstanton, paul.l..., gergely.kis.imgtec, akos.palfi.imgtec
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Eliminate special keyed load string stub in favor of uniform handlers. Port r24661 (5499efb) Original commit message: KeyedLoadIC installs a special case if the receiver is a string. Although there are several maps for strings, in practice we seem to be able to treat them individually because a given KeyedLoad site only sees 1-2 string types. BUG= R=paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=24668

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+28 lines, -26 lines)
M src/ic/mips64/ic-mips64.cc View 1 chunk +0 lines, -26 lines 0 comments
M src/mips64/code-stubs-mips64.cc View 1 chunk +28 lines, -0 lines 0 comments

Messages

Total messages: 4 (1 generated)
balazs.kilvady
6 years, 2 months ago (2014-10-16 16:29:09 UTC) #2
paul.l...
lgtm
6 years, 2 months ago (2014-10-16 16:37:57 UTC) #3
balazs.kilvady
6 years, 2 months ago (2014-10-16 16:39:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24668 (presubmit successful).

Powered by Google App Engine