Issue 6574011: Cleanup:...

Issue 6574011: Cleanup:... (Closed)

Created:
9 years, 10 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, pam+watch_chromium.org, Ilya Sherman, brettw-cc_chromium.org, James Hawkins, dhollowa

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup: * Remove InfoBarTextButton and just use a normal views::TextButton. The custom things InfoBarTextButton wanted to do (like fixing some button sizing issues) are now part of the base TextButton. * Restore the "needs elevation" badge for the "set default browser" infobar, which was lost in http://src.chromium.org/viewvc/chrome?view=rev&revision=70913 . * Factor out common code for creating buttons, labels, and links into static methods on InfoBarView. * Remove the ability of LinkInfoBar to draw links right-aligned, which was unused. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75821

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -281 lines)			Patch
M	chrome/browser/alternate_nav_url_fetcher.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/autofill/autofill_cc_infobar_win.cc	View		3 chunks	+7 lines, -14 lines	0 comments	Download
M	chrome/browser/tab_contents/infobar_delegate.h	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/tab_contents/infobar_delegate.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/cocoa/infobars/infobar_test_helper.mm	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/infobars/after_translate_infobar.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/after_translate_infobar.cc	View		2 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/before_translate_infobar.h	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/before_translate_infobar.cc	View		2 chunks	+11 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/confirm_infobar.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/confirm_infobar.cc	View		3 chunks	+13 lines, -28 lines	0 comments	Download
D	chrome/browser/ui/views/infobars/infobar_text_button.h	View		1 chunk	+0 lines, -38 lines	0 comments	Download
D	chrome/browser/ui/views/infobars/infobar_text_button.cc	View		1 chunk	+0 lines, -57 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/infobar_view.h	View		2 chunks	+24 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/infobar_view.cc	View		3 chunks	+83 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/link_infobar.cc	View		3 chunks	+10 lines, -47 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/translate_infobar_base.h	View		2 chunks	+1 line, -11 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/translate_infobar_base.cc	View		1 chunk	+0 lines, -40 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/translate_message_infobar.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/translate_message_infobar.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/6574011/diff/1/chrome/browser/ui/views/infobars/infobar_view.cc File chrome/browser/ui/views/infobars/infobar_view.cc (right): http://codereview.chromium.org/6574011/diff/1/chrome/browser/ui/views/infobars/infobar_view.cc#newcode30 chrome/browser/ui/views/infobars/infobar_view.cc:30: #include <shellapi.h> Shouldn't this include be at line ...

9 years, 10 months ago (2011-02-23 22:55:32 UTC) #2

Peter Kasting

9 years, 10 months ago (2011-02-23 23:06:45 UTC) #3

http://codereview.chromium.org/6574011/diff/1/chrome/browser/ui/views/infobar...
File chrome/browser/ui/views/infobars/infobar_view.cc (right):

http://codereview.chromium.org/6574011/diff/1/chrome/browser/ui/views/infobar...
chrome/browser/ui/views/infobars/infobar_view.cc:30: #include <shellapi.h>
On 2011/02/23 22:55:32, sky wrote:
> Shouldn't this include be at line 7?

Elliot and I both think here is better.

Expand Messages | Collapse Messages