Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 657383004: Alter layer hoisting to only hoist layers for one canvas at a time (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
jvanverth1, *bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Alter layer hoisting to only hoist layers for one canvas at a time This CL alters layer hoisting to defer creation of the free floating layers until they are actually needed (rather than creating _all_ the hoisted layers at the start). It also fixes a pre vs. post Concat bug with how matrices were being accumulated. BUG=skia:2315 Committed: https://skia.googlesource.com/skia/+/fd61ed0d7929cf85e0b936f48c72035af4c0a4b3

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : Turn off hoisting #

Patch Set 4 : More clean up #

Patch Set 5 : fix noGPU build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -160 lines) Patch
M src/core/SkMultiPictureDraw.cpp View 1 2 3 4 3 chunks +42 lines, -9 lines 0 comments Download
M src/gpu/GrLayerCache.h View 1 2 3 3 chunks +18 lines, -8 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 4 chunks +30 lines, -23 lines 0 comments Download
M src/gpu/GrLayerHoister.h View 1 2 3 1 chunk +38 lines, -25 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 1 2 3 9 chunks +100 lines, -85 lines 0 comments Download
M src/gpu/GrPictureUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 1 chunk +20 lines, -7 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
6 years, 2 months ago (2014-10-23 18:03:16 UTC) #4
bsalomon
On 2014/10/23 18:03:16, robertphillips wrote: (rubber stamp) lgtm
6 years, 2 months ago (2014-10-24 15:11:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657383004/60001
6 years, 1 month ago (2014-10-27 12:14:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/264) Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/261)
6 years, 1 month ago (2014-10-27 12:15:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657383004/80001
6 years, 1 month ago (2014-10-28 14:13:13 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 14:21:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as fd61ed0d7929cf85e0b936f48c72035af4c0a4b3

Powered by Google App Engine
This is Rietveld 408576698