DevTools: clear session id. follow-up patch after r183608

DevTools: follow-up patch after r183608

We have to clear sessionId not only at the end but also after disconnecting frontend.
Othervise it will be not null for the next devtools session and might be republished at navigation and break tracing session for the other tab.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183867

[loislo, 2014-10-16 13:24:11]

loislo@chromium.org changed reviewers:
+ caseq@chromium.org, pfeldman@chromium.org, vsevik@chromium.org,
yurys@chromium.org

[aandrey, 2014-10-16 15:38:21]

aandrey@chromium.org changed reviewers:
+ aandrey@chromium.org

[aandrey, 2014-10-16 15:38:22]

https://codereview.chromium.org/657383002/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorTracingAgent.cpp (right):

https://codereview.chromium.org/657383002/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorTracingAgent.cpp:43:
ASSERT(m_state->getString(TracingAgentState::sessionId) == String());
isEmpty()

https://codereview.chromium.org/657383002/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorTracingAgent.cpp:83:
m_state->setString(TracingAgentState::sessionId, String());
m_state->remove()

[loislo, 2014-10-17 06:23:21]

https://codereview.chromium.org/657383002/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorTracingAgent.cpp (right):

https://codereview.chromium.org/657383002/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorTracingAgent.cpp:43:
ASSERT(m_state->getString(TracingAgentState::sessionId) == String());
On 2014/10/16 15:38:22, aandrey wrote:
> isEmpty()

Done.

https://codereview.chromium.org/657383002/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorTracingAgent.cpp:83:
m_state->setString(TracingAgentState::sessionId, String());
On 2014/10/16 15:38:22, aandrey wrote:
> m_state->remove()

Done.

[yurys, 2014-10-17 06:29:35]

https://codereview.chromium.org/657383002/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorTracingAgent.cpp (right):

https://codereview.chromium.org/657383002/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorTracingAgent.cpp:84:
m_state->remove(TracingAgentState::sessionId);
You should also reset session id on the worker agent. Please extract this logic
in a separate method that can be called from both end and clearFrontend.

[loislo, 2014-10-17 07:12:00]

https://codereview.chromium.org/657383002/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorTracingAgent.cpp (right):

https://codereview.chromium.org/657383002/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorTracingAgent.cpp:84:
m_state->remove(TracingAgentState::sessionId);
On 2014/10/17 06:29:35, yurys wrote:
> You should also reset session id on the worker agent. Please extract this
logic
> in a separate method that can be called from both end and clearFrontend.

Done.

[yurys, 2014-10-17 08:00:54]

lgtm

https://codereview.chromium.org/657383002/diff/60001/LayoutTests/inspector/ti...
File LayoutTests/inspector/timeline/timeline-paint.html (right):

https://codereview.chromium.org/657383002/diff/60001/LayoutTests/inspector/ti...
LayoutTests/inspector/timeline/timeline-paint.html:27:
InspectorTest.startDumpingProtocolMessages();
Revert this?

https://codereview.chromium.org/657383002/diff/60001/LayoutTests/inspector/tr...
File LayoutTests/inspector/tracing/console-timeline.html (right):

https://codereview.chromium.org/657383002/diff/60001/LayoutTests/inspector/tr...
LayoutTests/inspector/tracing/console-timeline.html:80:
InspectorTest.startDumpingProtocolMessages();
ditto.

https://codereview.chromium.org/657383002/diff/60001/Source/core/inspector/In...
File Source/core/inspector/InspectorTracingAgent.cpp (right):

https://codereview.chromium.org/657383002/diff/60001/Source/core/inspector/In...
Source/core/inspector/InspectorTracingAgent.cpp:53: m_client->disableTracing();
Please move session id reset after disableTracing()

[loislo, 2014-10-17 08:04:40]

The CQ bit was checked by loislo@chromium.org

[commit-bot: I haz the power, 2014-10-17 08:05:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657383002/80001

[commit-bot: I haz the power, 2014-10-17 09:08:01]

Committed patchset #5 (id:80001) as 183867