chrome/browser/safe_browsing/protocol_manager.cc - Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/protocol_manager.cc

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/protocol_manager.cc

diff --git a/chrome/browser/safe_browsing/protocol_manager.cc b/chrome/browser/safe_browsing/protocol_manager.cc

index 64dc05be8346456ca305aa48f50931fd38aa8a31..7a39760d4f9241d51fdffa1dc1b83938d46abc49 100644

--- a/chrome/browser/safe_browsing/protocol_manager.cc

+++ b/chrome/browser/safe_browsing/protocol_manager.cc

@@ -73,8 +73,8 @@ static const size_t kSbMaxBackOff = 8;

class SBProtocolManagerFactoryImpl : public SBProtocolManagerFactory {

public:

SBProtocolManagerFactoryImpl() { }

- virtual ~SBProtocolManagerFactoryImpl() { }

- virtual SafeBrowsingProtocolManager* CreateProtocolManager(

+ ~SBProtocolManagerFactoryImpl() override {}

+ SafeBrowsingProtocolManager* CreateProtocolManager(

SafeBrowsingProtocolManagerDelegate* delegate,

net::URLRequestContextGetter* request_context_getter,

const SafeBrowsingProtocolConfig& config) override {

« no previous file with comments | « chrome/browser/safe_browsing/protocol_manager.h ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page.h » ('j') | no next file with comments »