chrome/browser/safe_browsing/malware_details_history.h - Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/malware_details_history.h

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/malware_details_cache.h ('k') | chrome/browser/safe_browsing/malware_details_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/malware_details_history.h

diff --git a/chrome/browser/safe_browsing/malware_details_history.h b/chrome/browser/safe_browsing/malware_details_history.h

index 319362648dbb3eae19fbd2fd2b77acc5ce5519fc..7482cc583784427e0521869715bf7052600e8e04 100644

--- a/chrome/browser/safe_browsing/malware_details_history.h

+++ b/chrome/browser/safe_browsing/malware_details_history.h

@@ -47,16 +47,16 @@ class MalwareDetailsRedirectsCollector

const std::vector<safe_browsing::RedirectChain>& GetCollectedUrls() const;

// content::NotificationObserver

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

private:

friend struct content::BrowserThread::DeleteOnThread<

content::BrowserThread::UI>;

friend class base::DeleteHelper<MalwareDetailsRedirectsCollector>;

- virtual ~MalwareDetailsRedirectsCollector();

+ ~MalwareDetailsRedirectsCollector() override;

void StartGetRedirects(const std::vector<GURL>& urls);

void GetRedirects(const GURL& url);

« no previous file with comments | « chrome/browser/safe_browsing/malware_details_cache.h ('k') | chrome/browser/safe_browsing/malware_details_unittest.cc » ('j') | no next file with comments »