Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6584)

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host.h

Issue 657373004: Standardize usage of virtual/override/final in chrome/browser/safe_browsing/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/client_side_detection_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/client_side_detection_host.h
diff --git a/chrome/browser/safe_browsing/client_side_detection_host.h b/chrome/browser/safe_browsing/client_side_detection_host.h
index 77ed9e3adca5c1ccc82129aa1d870b64750d80dc..2384e35c1b72d8f9e1a6c9c4b7abe0229b3eb846 100644
--- a/chrome/browser/safe_browsing/client_side_detection_host.h
+++ b/chrome/browser/safe_browsing/client_side_detection_host.h
@@ -35,26 +35,26 @@ class ClientSideDetectionHost : public content::WebContentsObserver,
// The caller keeps ownership of the tab object and is responsible for
// ensuring that it stays valid until WebContentsDestroyed is called.
static ClientSideDetectionHost* Create(content::WebContents* tab);
- virtual ~ClientSideDetectionHost();
+ ~ClientSideDetectionHost() override;
// From content::WebContentsObserver.
- virtual bool OnMessageReceived(const IPC::Message& message) override;
+ bool OnMessageReceived(const IPC::Message& message) override;
// From content::WebContentsObserver. If we navigate away we cancel all
// pending callbacks that could show an interstitial, and check to see whether
// we should classify the new URL.
- virtual void DidNavigateMainFrame(
+ void DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) override;
// Called when the SafeBrowsingService found a hit with one of the
// SafeBrowsing lists. This method is called on the UI thread.
- virtual void OnSafeBrowsingHit(
+ void OnSafeBrowsingHit(
const SafeBrowsingUIManager::UnsafeResource& resource) override;
// Called when the SafeBrowsingService finds a match on the SB lists.
// Called on the UI thread. Called even if the resource is whitelisted.
- virtual void OnSafeBrowsingMatch(
+ void OnSafeBrowsingMatch(
const SafeBrowsingUIManager::UnsafeResource& resource) override;
virtual scoped_refptr<SafeBrowsingDatabaseManager> database_manager();
@@ -67,7 +67,7 @@ class ClientSideDetectionHost : public content::WebContentsObserver,
explicit ClientSideDetectionHost(content::WebContents* tab);
// From content::WebContentsObserver.
- virtual void WebContentsDestroyed() override;
+ void WebContentsDestroyed() override;
// Used for testing.
void set_safe_browsing_managers(
@@ -122,13 +122,13 @@ class ClientSideDetectionHost : public content::WebContentsObserver,
// From NotificationObserver. Called when a notification comes in. This
// method is called in the UI thread.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
// Inherited from WebContentsObserver. This is called once the page is
// done loading.
- virtual void DidStopLoading(content::RenderViewHost* rvh) override;
+ void DidStopLoading(content::RenderViewHost* rvh) override;
// Returns true if the user has seen a regular SafeBrowsing
// interstitial for the current page. This is only true if the user has
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/client_side_detection_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698