Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 657353002: Mixed Content: Re-allow non-webby URLs in IFrames. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Mixed Content: Re-allow non-webby URLs in IFrames. We settled on this compromise in https://src.chromium.org/viewvc/blink?revision=178148&view=revision and it regressed sometime between then and now. I've added a layout test (which I should have done in the first place) to ensure that doesn't happen again. This CL also changes the test driver to accept '.https.html' as an HTTPS-by-default toggle. This is a nice addition to the existing functionality that doesn't force us to put HTTPS-by-default tests into a separate directory. BUG=422213, 318788 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184265

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -3 lines) Patch
A LayoutTests/http/tests/security/mixedContent/nonwebby-scheme-in-iframe-allowed.https.html View 1 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/mixedContent/nonwebby-scheme-in-iframe-allowed.https-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/loader/MixedContentChecker.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/driver.py View 1 chunk +4 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mike West
Mind taking a look?
6 years, 2 months ago (2014-10-17 13:30:08 UTC) #2
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/657353002/diff/1/LayoutTests/http/tests/security/mixedContent/nonwebby-scheme-in-iframe-allowed.https.html File LayoutTests/http/tests/security/mixedContent/nonwebby-scheme-in-iframe-allowed.https.html (right): https://codereview.chromium.org/657353002/diff/1/LayoutTests/http/tests/security/mixedContent/nonwebby-scheme-in-iframe-allowed.https.html#newcode5 LayoutTests/http/tests/security/mixedContent/nonwebby-scheme-in-iframe-allowed.https.html:5: This tests that non-webby URLs are not blocked ...
6 years, 2 months ago (2014-10-20 13:28:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657353002/20001
6 years, 2 months ago (2014-10-23 11:09:54 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 13:08:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184265

Powered by Google App Engine
This is Rietveld 408576698