Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 657313005: ReceiverCheckMode needs to be utilized further. (Closed)

Created:
6 years, 2 months ago by mvstanton
Modified:
6 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

ReceiverCheckMode needs to be utilized further. The parameter wasn't being passed appropriately, and there was an extra opportunity to use mode RECEIVER_IS_STRING in SubStringStub. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mvstanton
Hi Yang, Here is the minor issue we discussed today. Just a slight reduction in ...
6 years, 2 months ago (2014-10-17 16:07:11 UTC) #2
Yang
On 2014/10/17 16:07:11, mvstanton wrote: > Hi Yang, > Here is the minor issue we ...
6 years, 2 months ago (2014-10-17 16:09:57 UTC) #3
mvstanton
6 years, 2 months ago (2014-10-17 16:23:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24704 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698