Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: sky/engine/core/BUILD.gn

Issue 657303006: Use process_in_files helper for make_core_generated_html_element_lookup_trie (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/BUILD.gn
diff --git a/sky/engine/core/BUILD.gn b/sky/engine/core/BUILD.gn
index 24c8cf542db9c6329be3492cee872e4ee6772b29..826f3804c1fed37683171ebaa65967a770c3d152 100644
--- a/sky/engine/core/BUILD.gn
+++ b/sky/engine/core/BUILD.gn
@@ -93,9 +93,6 @@ source_set("core_generated") {
sources += bindings_core_generated_aggregate_files
sources += [
- "$sky_core_output_dir/HTMLElementLookupTrie.cpp",
- "$sky_core_output_dir/HTMLElementLookupTrie.h",
-
# Generated from HTMLEntityNames.in
"$sky_core_output_dir/HTMLEntityTable.cpp",
@@ -483,12 +480,12 @@ action("make_core_generated_media_query_tokenizer_codepoints") {
deps = make_core_generated_deps
}
-action("make_core_generated_html_element_lookup_trie") {
+process_in_files("make_core_generated_html_element_lookup_trie") {
script = "../build/scripts/make_element_lookup_trie.py"
-
- input_file = "html/HTMLTagNames.in"
- inputs = scripts_for_in_files + [
- input_file,
+ in_files = [
+ "html/HTMLTagNames.in",
+ ]
+ other_inputs = [
"../build/scripts/templates/ElementLookupTrie.cpp.tmpl",
"../build/scripts/templates/ElementLookupTrie.h.tmpl",
]
@@ -496,13 +493,10 @@ action("make_core_generated_html_element_lookup_trie") {
"$sky_core_output_dir/HTMLElementLookupTrie.cpp",
"$sky_core_output_dir/HTMLElementLookupTrie.h",
]
-
- args = [
- rebase_path(input_file, root_build_dir),
- "--output_dir", rel_sky_core_gen_dir,
+ deps = [
+ ":core_names",
+ ":libraries",
]
-
- deps = make_core_generated_deps
}
action_foreach("make_core_generated_bison") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698