Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 657303006: Use process_in_files helper for make_core_generated_html_element_lookup_trie (Closed)

Created:
6 years, 2 months ago by eseidel
Modified:
6 years, 2 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Use process_in_files helper for make_core_generated_html_element_lookup_trie This lets us get rid of the manual source listing in core_generated R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ae2e8feeb1e395ca0594522e620ebd95837871f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M sky/engine/core/BUILD.gn View 3 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
6 years, 2 months ago (2014-10-24 22:43:40 UTC) #2
abarth-chromium
lgtm
6 years, 2 months ago (2014-10-24 22:44:27 UTC) #3
eseidel
6 years, 2 months ago (2014-10-24 22:46:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ae2e8feeb1e395ca0594522e620ebd95837871f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698