Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 657283003: Remove workaround in Sync supervised users test (Closed)

Created:
6 years, 2 months ago by pval...(no longer on Chromium)
Modified:
6 years, 2 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, pam+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Remove workaround in Sync supervised users test Now that crbug.com/422508 is fixed, we can remove the call that made the test work. BUG=422508 Committed: https://crrev.com/82d056a6c81cffbbbe216ece04105227cd38fd99 Cr-Commit-Position: refs/heads/master@{#300026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M chrome/browser/sync/test/integration/single_client_supervised_user_settings_sync_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pval...(no longer on Chromium)
6 years, 2 months ago (2014-10-16 21:19:09 UTC) #2
Nicolas Zea
lgtm
6 years, 2 months ago (2014-10-16 21:20:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657283003/1
6 years, 2 months ago (2014-10-16 21:27:11 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-16 23:30:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657283003/1
6 years, 2 months ago (2014-10-17 00:31:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 00:33:23 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 00:34:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82d056a6c81cffbbbe216ece04105227cd38fd99
Cr-Commit-Position: refs/heads/master@{#300026}

Powered by Google App Engine
This is Rietveld 408576698