Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: Source/core/frame/Frame.cpp

Issue 657263002: Disallow script execution after unload event dispatch in frame detach. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/LocalFrame.cpp » ('j') | Source/core/frame/RemoteFrame.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/Frame.cpp
diff --git a/Source/core/frame/Frame.cpp b/Source/core/frame/Frame.cpp
index d45db355c975bbb0c7041fed3c7f2504b8a9c281..56072e83d8c9e3bec9bbaa80407938a9d70eb670 100644
--- a/Source/core/frame/Frame.cpp
+++ b/Source/core/frame/Frame.cpp
@@ -103,12 +103,6 @@ void Frame::trace(Visitor* visitor)
void Frame::detach()
{
- // client() should never be null because that means we somehow re-entered
- // the frame detach code... but it is sometimes.
- // FIXME: Understand why this is happening so we can document this insanity.
- // http://crbug.com/371084 is a probable explanation.
- if (!client())
- return;
haraken 2014/10/16 00:59:27 Shall we add ASSERT(client())?
dcheng 2014/10/16 01:21:32 Done.
// After this, we must no longer talk to the client since this clears
// its owning reference back to our owning LocalFrame.
m_client->detached();
« no previous file with comments | « no previous file | Source/core/frame/LocalFrame.cpp » ('j') | Source/core/frame/RemoteFrame.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698