Fix autofill test data.

Fix autofill test data.

The discussion at [1] gives some background on the root cause of the failure.

[1] https://codereview.chromium.org/610493002/

BUG=323093
Committed: https://crrev.com/9116f484558d3b35c9b1e14185ad43c557656192
Cr-Commit-Position: refs/heads/master@{#299965}

[Evan Stade, 2014-10-16 01:12:42]

estade@chromium.org changed reviewers:
+ isherman@chromium.org

[Ilya Sherman, 2014-10-16 03:19:18]

Can you explain in a bit of detail what is being misparsed to create the test
failure?  I bet we can work around the issue without actually changing the
semantics of the test data.

https://codereview.chromium.org/657253003/diff/20001/chrome/test/data/autofil...
File chrome/test/data/autofill/heuristics/input/16_crbug_98286.html (right):

https://codereview.chromium.org/657253003/diff/20001/chrome/test/data/autofil...
chrome/test/data/autofill/heuristics/input/16_crbug_98286.html:1: <!--
https://www.jcpenney.com/dotcom/jsp/checkout/secure/checkout.jsp -->
Why did you choose jcpenney.com?  I think that it's useful to have the URL that
the form comes from.  If, for some reason, we can't do that; then I would prefer
to have no URL than a fake URL.  However, I'm not convinced that we really can't
have the full original URL here.

[Evan Stade, 2014-10-16 16:28:13]

On 2014/10/16 03:19:18, Ilya Sherman wrote:
> Can you explain in a bit of detail what is being misparsed to create the test
> failure?  I bet we can work around the issue without actually changing the
> semantics of the test data.

See https://codereview.chromium.org/610493002/

Although unintuitive, the hash mark in the HTML comment delimits the beginning
of the fragment identifier. Since this input file and the previous one
(16_crbug_93595.html) are identical up until the hash, a navigation from one to
the next is not considered a navigation to a new page, so forms are not
reparsed.

https://codereview.chromium.org/657253003/diff/20001/chrome/test/data/autofil...
File chrome/test/data/autofill/heuristics/input/16_crbug_98286.html (right):

https://codereview.chromium.org/657253003/diff/20001/chrome/test/data/autofil...
chrome/test/data/autofill/heuristics/input/16_crbug_98286.html:1: <!--
https://www.jcpenney.com/dotcom/jsp/checkout/secure/checkout.jsp -->
On 2014/10/16 03:19:18, Ilya Sherman wrote:
> Why did you choose jcpenney.com?  I think that it's useful to have the URL
that
> the form comes from.  If, for some reason, we can't do that; then I would
prefer
> to have no URL than a fake URL.  However, I'm not convinced that we really
can't
> have the full original URL here.

this is the URL the test came from. The jbox url was a copy pasta error. See
crbug.com/98286

[Ilya Sherman, 2014-10-16 18:30:54]

Thanks.  LGTM % URL typo:

https://codereview.chromium.org/657253003/diff/20001/chrome/test/data/autofil...
File chrome/test/data/autofill/heuristics/input/16_crbug_98286.html (right):

https://codereview.chromium.org/657253003/diff/20001/chrome/test/data/autofil...
chrome/test/data/autofill/heuristics/input/16_crbug_98286.html:1: <!--
https://www.jcpenney.com/dotcom/jsp/checkout/secure/checkout.jsp -->
On 2014/10/16 16:28:13, Evan Stade wrote:
> On 2014/10/16 03:19:18, Ilya Sherman wrote:
> > Why did you choose jcpenney.com?  I think that it's useful to have the URL
> that
> > the form comes from.  If, for some reason, we can't do that; then I would
> prefer
> > to have no URL than a fake URL.  However, I'm not convinced that we really
> can't
> > have the full original URL here.
> 
> this is the URL the test came from. The jbox url was a copy pasta error. See
> crbug.com/98286

Oh, wow.  Good catch, then.  Still, I'm guessing the URL is at least jcpenny
rather than jcpenney, right? :)

[Evan Stade, 2014-10-16 18:47:20]

https://codereview.chromium.org/657253003/diff/20001/chrome/test/data/autofil...
File chrome/test/data/autofill/heuristics/input/16_crbug_98286.html (right):

https://codereview.chromium.org/657253003/diff/20001/chrome/test/data/autofil...
chrome/test/data/autofill/heuristics/input/16_crbug_98286.html:1: <!--
https://www.jcpenney.com/dotcom/jsp/checkout/secure/checkout.jsp -->
On 2014/10/16 18:30:54, Ilya Sherman wrote:
> On 2014/10/16 16:28:13, Evan Stade wrote:
> > On 2014/10/16 03:19:18, Ilya Sherman wrote:
> > > Why did you choose jcpenney.com?  I think that it's useful to have the URL
> > that
> > > the form comes from.  If, for some reason, we can't do that; then I would
> > prefer
> > > to have no URL than a fake URL.  However, I'm not convinced that we really
> > can't
> > > have the full original URL here.
> > 
> > this is the URL the test came from. The jbox url was a copy pasta error. See
> > crbug.com/98286
> 
> Oh, wow.  Good catch, then.  Still, I'm guessing the URL is at least jcpenny
> rather than jcpenney, right? :)

nope, jcpenney

[Evan Stade, 2014-10-16 18:47:24]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-10-16 18:49:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/657253003/20001

[Ilya Sherman, 2014-10-16 18:51:09]

On 2014/10/16 18:47:20, Evan Stade wrote:
>
https://codereview.chromium.org/657253003/diff/20001/chrome/test/data/autofil...
> File chrome/test/data/autofill/heuristics/input/16_crbug_98286.html (right):
> 
>
https://codereview.chromium.org/657253003/diff/20001/chrome/test/data/autofil...
> chrome/test/data/autofill/heuristics/input/16_crbug_98286.html:1: <!--
> https://www.jcpenney.com/dotcom/jsp/checkout/secure/checkout.jsp -->
> On 2014/10/16 18:30:54, Ilya Sherman wrote:
> > On 2014/10/16 16:28:13, Evan Stade wrote:
> > > On 2014/10/16 03:19:18, Ilya Sherman wrote:
> > > > Why did you choose jcpenney.com?  I think that it's useful to have the
URL
> > > that
> > > > the form comes from.  If, for some reason, we can't do that; then I
would
> > > prefer
> > > > to have no URL than a fake URL.  However, I'm not convinced that we
really
> > > can't
> > > > have the full original URL here.
> > > 
> > > this is the URL the test came from. The jbox url was a copy pasta error.
See
> > > crbug.com/98286
> > 
> > Oh, wow.  Good catch, then.  Still, I'm guessing the URL is at least jcpenny
> > rather than jcpenney, right? :)
> 
> nope, jcpenney

Huh, apparently jcpenny.com redirects... and also I've been misspelling the name
of this store for my entire life.  Good to know :P

[Evan Stade, 2014-10-16 18:57:17]

On 2014/10/16 18:51:09, Ilya Sherman wrote:
> On 2014/10/16 18:47:20, Evan Stade wrote:
> >
>
https://codereview.chromium.org/657253003/diff/20001/chrome/test/data/autofil...
> > File chrome/test/data/autofill/heuristics/input/16_crbug_98286.html (right):
> > 
> >
>
https://codereview.chromium.org/657253003/diff/20001/chrome/test/data/autofil...
> > chrome/test/data/autofill/heuristics/input/16_crbug_98286.html:1: <!--
> > https://www.jcpenney.com/dotcom/jsp/checkout/secure/checkout.jsp -->
> > On 2014/10/16 18:30:54, Ilya Sherman wrote:
> > > On 2014/10/16 16:28:13, Evan Stade wrote:
> > > > On 2014/10/16 03:19:18, Ilya Sherman wrote:
> > > > > Why did you choose jcpenney.com?  I think that it's useful to have the
> URL
> > > > that
> > > > > the form comes from.  If, for some reason, we can't do that; then I
> would
> > > > prefer
> > > > > to have no URL than a fake URL.  However, I'm not convinced that we
> really
> > > > can't
> > > > > have the full original URL here.
> > > > 
> > > > this is the URL the test came from. The jbox url was a copy pasta error.
> See
> > > > crbug.com/98286
> > > 
> > > Oh, wow.  Good catch, then.  Still, I'm guessing the URL is at least
jcpenny
> > > rather than jcpenney, right? :)
> > 
> > nope, jcpenney
> 
> Huh, apparently http://jcpenny.com redirects... and also I've been misspelling
the name
> of this store for my entire life.  Good to know :P

you're probably not the only one.

[commit-bot: I haz the power, 2014-10-16 20:16:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-16 20:17:17]

Patchset 2 (id:??) landed as
https://crrev.com/9116f484558d3b35c9b1e14185ad43c557656192
Cr-Commit-Position: refs/heads/master@{#299965}