Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 657233002: Ensure that the browser’s copy of page id is in sync with the renderer’s. (Closed)

Created:
6 years, 2 months ago by Avi (use Gerrit)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ensure that the browser’s copy of page id is in sync with the renderer’s. This might-maybe-hope-not crash, and so has debugging statements. BUG=407376 TEST=no crashing, we hope Committed: https://crrev.com/b49b70f26e6d0f2f54bb87cf374f30a339c7d7c6 Cr-Commit-Position: refs/heads/master@{#299822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M chrome/common/crash_keys.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Avi (use Gerrit)
You know the drill.
6 years, 2 months ago (2014-10-15 22:30:12 UTC) #2
Robert Sesek
LGTM. I do not envy you, having to work on this bug.
6 years, 2 months ago (2014-10-15 22:31:21 UTC) #3
Charlie Reis
LGTM. Let's hope https://codereview.chromium.org/659843002/ fixed the underlying bug!
6 years, 2 months ago (2014-10-15 22:35:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657233002/1
6 years, 2 months ago (2014-10-15 22:39:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 02:25:28 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b49b70f26e6d0f2f54bb87cf374f30a339c7d7c6 Cr-Commit-Position: refs/heads/master@{#299822}
6 years, 2 months ago (2014-10-16 02:26:17 UTC) #8
Avi (use Gerrit)
6 years, 2 months ago (2014-10-16 18:56:13 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/661823002/ by avi@chromium.org.

The reason for reverting is: It's crashing... drat..

Powered by Google App Engine
This is Rietveld 408576698