Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2243)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

Issue 657213004: ServiceWorker: Issue a warning after initial execution of worker script (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Incorporate reviews and rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/workers/WorkerThread.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
index df83c0dec1c8d21a2709e3b92692cda7743252c7..76f9115a805423e29d121663bab52111b41424ea 100644
--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
@@ -55,7 +55,10 @@ public:
virtual ~ServiceWorkerGlobalScope();
virtual bool isServiceWorkerGlobalScope() const override { return true; }
+
+ // WorkerGlobalScope
virtual void stopFetch() override;
+ virtual void didEvaluateWorkerScript() override;
// ServiceWorkerGlobalScope.idl
ServiceWorkerClients* clients();
@@ -71,6 +74,7 @@ public:
void close(ExceptionState&);
// EventTarget
+ virtual bool addEventListener(const AtomicString& eventType, PassRefPtr<EventListener>, bool useCapture = false) override;
virtual const AtomicString& interfaceName() const override;
DEFINE_ATTRIBUTE_EVENT_LISTENER(install);
@@ -89,6 +93,7 @@ private:
PersistentWillBeMember<ServiceWorkerClients> m_clients;
OwnPtr<FetchManager> m_fetchManager;
PersistentWillBeMember<CacheStorage> m_caches;
+ bool m_didEvaluateScript;
};
} // namespace blink
« no previous file with comments | « Source/core/workers/WorkerThread.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698