Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 657203002: The ScaleImageSkiaRep function which attempts to scale the image to the desired scale should not do… (Closed)

Created:
6 years, 2 months ago by ananta
Modified:
6 years, 2 months ago
Reviewers:
Jun Mukai, oshima
CC:
chromium-reviews, rsesek+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

The ScaleImageSkiaRep function which attempts to scale the image to the desired scale should not do anything if the image is already scaled to the required scale. The FindRepresentation function in ImageSkiaStorage has support for returning images scaled to the desired scale. This fixes an annoying DCHECK firing on Windows boxes with display scales like 125%, 150%, etc. BUG=NONE Committed: https://crrev.com/fd31940eaea7d4a21c5f2ad3e2786259621edf65 Cr-Commit-Position: refs/heads/master@{#299825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ui/gfx/image/image_skia.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
ananta
6 years, 2 months ago (2014-10-15 21:52:38 UTC) #2
oshima
-> mukai
6 years, 2 months ago (2014-10-15 22:20:54 UTC) #4
Jun Mukai
lgtm
6 years, 2 months ago (2014-10-15 23:11:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657203002/1
6 years, 2 months ago (2014-10-15 23:17:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17905)
6 years, 2 months ago (2014-10-15 23:28:45 UTC) #9
oshima
lgtm
6 years, 2 months ago (2014-10-15 23:34:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657203002/1
6 years, 2 months ago (2014-10-15 23:46:26 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 02:36:03 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 02:36:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd31940eaea7d4a21c5f2ad3e2786259621edf65
Cr-Commit-Position: refs/heads/master@{#299825}

Powered by Google App Engine
This is Rietveld 408576698